1858144 - Tabs can be restored after deleting private session data

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[Simona Badau, Desktop QA]

Found in

• Nightly 120.0a1

Affected versions

• Nightly 120.0a1

Tested platforms

• Affected platforms: macOS 12, Ubuntu 22.04, Windows 11

Steps to reproduce

1. Launch a private window.
2. Browse various websites.
3. Delete the session by clicking on the "End Private Session" button.
4. Press the Ctrl+Shift+T keys.

Expected result

• After deleting the session data the closed tabs should not be restored.

Actual result

• All tabs opened during step 2 are restored even after ending the private session.

Regression range
Not a regression.

Additional notes

• Setting the severity of this issue to S2 - as it should not be possible to recover deleted browsing history after ending the private session.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sbadau, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1858144 - Clear session store closed tabs on reset PBM action. r=dao!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5a9849f8707
Clear session store closed tabs on reset PBM action. r=sessionstore-reviewers,sfoster

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e5a9849f8707

Comment 5

[Simona Badau, Desktop QA]

Attachment: Screen recording

I can still reproduce this issue on the latest Nightly 120.0a1, BuilD ID: 20231019213231 - on macOS 11.7, Ubuntu 22.04, and Windows 10 x64.

Paul, could you please take a look?

Comment 6

[Emma Zühlcke [:emz]]

Thanks! This is indeed not fully fixed. Sometimes I can still restore tabs.

Comment 7

[Emma Zühlcke [:emz]]

Let's spin this off into a separate bug.

Comment 8

[Simona Badau, Desktop QA]

Considering Bug 1861215 was filed to cover the intermittent restoring of the tabs, I'm marking this as Verified Fixed on Firefox 120.0b4.