185823 - wideroe.no - 'search for flight' not working. JS-error

Status: VERIFIED FIXED

(Tech Evangelism Graveyard :: Norwegian, defect)

Description

[Marius Kotsbak]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021212
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021212

I get the following JS error 

Error: itinerary is not defined
Source File: http://www.wideroe.no/front.shtml
Line: 219

Reproducible: Always

Steps to Reproduce:
1. Go to www.wideroe.no
2. Press "Start søk" (start search) in the form. There is no need to fill out
anything to get the JS-error.


Actual Results:  
Nothing happens

Expected Results:  
Result of the flight search should be presented.

I have contacted them. They first said they were only going to support MS IE
because 100%-some % are using it. Now they are making parts of the site
compatible with mozilla and are more positive to fixing incompatibility. I think
they will accept a complete solution to this problem.

Comment 1

[Marius Kotsbak]

BTW: There is a english (and german) translation of the page here:
http://www.wideroe.no/english/index.html (or press the appropriate flag on the
top) which has the same problem for english-speakning people.

Comment 2

[Sébastien Delahaye]

*** Bug 185822 has been marked as a duplicate of this bug. ***

Comment 3

[Brant Gurganus]

My connection is refused.

Comment 4

[Marius Kotsbak]

Please try again. No problem for me now. (They might have done some maintainance
during what is night in Norway.)

I think I fixed the JS-error I noted by replacing "itinerary" with
document.getElementById('itinerary'). Why can't mozilla just accept "itinerary."?

Comment 5

[Brant Gurganus]

NEW 2002121408

My guess is that line:
document.itinerary.submit();
should be:
document.forms.itinerary.submit();

Comment 6

[Mathieu Pillard [:mat]]

brant is right, but thats not the only line concerned. (a cleaner way imho is to
use document.forms["something"])

Comment 7

[Marius Kotsbak]

After fixing the first line in getcDepature-function (which is the first one
that it complains about):

<script type="text/javascript" language="JavaScript">

<!-- Begin

function getcDeparture(){

   depString = document.forms["itinerary"].departure.value;

   depSplit = depString.split('/');

   depDay = depSplit[0];

   depMonth = depSplit[1];

   depYear = depSplit[2];

   depString = depDay + '/' + depYear + depMonth;

   depSplit = depString.split('/');

   depDay = depSplit[0];

   depMonth = depSplit[1];

   document.forms.itinerary.D_Day.value = depDay;

   document.forms.itinerary.D_Month.value = depMonth;

}


it complains about:
"Error: depString has no properties
Source File: file:///home/marius/tmp/front.shtml
Line: 216"

which is the second line with "split". What is wrong with that one?

Comment 8

[Marius Kotsbak]

I found out myself. The split-problem happened when no text was entered in that
field. Should probably be checked by the javascript though.

Comment 9

[Marius Kotsbak]

Attachment: How to fix the page

Comment 10

[Marius Kotsbak]

I have entered a Enhancement request for a general solution to this syntax error
in bug #187380

Comment 11

[Marius Kotsbak]

I got a response from the webmaster :-) (translation below). The problem seems
to be resolved for mozilla, so I close the bug.

Hei Marius,

Tusen takk for hjelpen. Widerøes forside er nå rettet opp.
Vi har skaffet oss Netscape 7 for testing. Det fungerer like
bra for Microsoft Explorer som for Netscape 7 nå.
Vi skal arbeide oss gjennom nettstedet og rette opp fortløpende.
Gi gjerne tilbakemeldinger om områder av vårt nettsted du ønsker
prioritert (hastesaker).

Med vennlig hilsen fra
Terje Normann Waage

Webmaster, Widerøe

==================
Quick translation:
==================

Hi Marius

Thanks for your help. Wideroes front side is now corrected. We have obtained
Netscape 7 for testing. It works as well in MS IE as in Netscape 7 now. We are
going to work through the website and correct continuously. You are welcome to
give feedback about parts of our website that you want prioritized.

Webmaster, Wideroe

Comment 12

[Brant Gurganus]

v

Comment 13

[Bob Clary [:bc] (inactive)]

tech evang june 2003 reorg