Closed Bug 1858358 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42477 - [text-autospace][text-spacing-trim] Support `text-spacing` shorthand

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42477 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42477
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[text-autospace][text-spacing-trim] Support text-spacing shorthand

This patch supports the text-spacing shorthand[1], which is
for text-autospace and text-spacing-trim.

The normal and none preset values are supported, but the
auto isn't supported because it's not supported in
text-autospace and text-spacing-trim either.

[1] https://drafts.csswg.org/css-text-4/#text-spacing-property

Bug: 1463890, 1463891
Change-Id: Ic2f7a72502f52c3ab111801daf541850ffcf2998

Reviewed-on: https://chromium-review.googlesource.com/4927468
WPT-Export-Revision: b6b534fe815c56fff410fb66f8459594f1f991ce

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 12 subtests

Status Summary

Firefox

OK : 3
PASS: 15
FAIL: 24

Chrome

OK : 3
PASS: 15
FAIL: 24

Safari

OK : 3
PASS: 15
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-text/parsing/text-spacing-computed.html [wpt.fyi]
    • Property text-spacing value 'normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'none': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'auto': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'no-autospace': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'space-first': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'space-all': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'allow-end space-first': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'space-first allow-end': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'no-autospace space-first': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'no-autospace space-all': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'space-first no-autospace': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property text-spacing value 'space-all no-autospace': FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-text/parsing/text-spacing-valid.html [wpt.fyi]
    • e.style['text-spacing'] = "normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "none" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "no-autospace" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "space-first" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "space-all" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "allow-end space-first" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "space-first allow-end" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "no-autospace space-first" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "no-autospace space-all" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "space-first no-autospace" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['text-spacing'] = "space-all no-autospace" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2da9a858f0b1 [wpt PR 42477] - [text-autospace][text-spacing-trim] Support `text-spacing` shorthand, a=testonly https://hg.mozilla.org/integration/autoland/rev/b0ea0cfe1fe4 [wpt PR 42477] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2da9a858f0b1
https://hg.mozilla.org/mozilla-central/rev/b0ea0cfe1fe4

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.