1858498 - Do not show post-install dialog during updates

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, enhancement)

Description

[William Durand [:willdurand]]

When we update an extension, onInstalled() is going to be called, which eventually shows a post-install dialog. In this case, we shouldn't show the post-install dialog in this case.

Comment 1

[William Durand [:willdurand]]

We can also reproduce this bug with web-ext: ideally, reloading the add-on after a change shouldn't display the post-install popup.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1858498 - Do not show post-install dialog during updates (#4046)

Comment 3

[BMO Github Automation]

Authored by https://github.com/willdurand
https://github.com/mozilla-mobile/firefox-android/commit/7241014428460d0b1069e70293aff8a6f0d25bfa
[main] Bug 1858498 - Do not show post-install dialog during updates

Comment 4

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly 120.0a1 (Build #2015979618), 9f2286a0f0+, GV: 120.0a1-20231012093726, AS: 120.20231012050441 using an Oppo Reno6 5G running Android 13.

As per Comment 1, I loaded https://addons.mozilla.org/en-US/firefox/addon/open-with-vlc/ with web-ext and initially the post-install dialog is shown. I then made some changes to the add-on manifest.json file (changed the version number) and once the add-on was reloaded, no post install dialog was shown as expected. Version was changed to what I modified earlier so the process was valid.