1858584 - update region lists for deciding whom to show VPN promos to

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

This is a spin-off from bug 1857903. There are several lists in BrowserUtils.shouldShowPromo that are not up-to-date with the latest canonical bedrock lists.

https://searchfox.org/mozilla-central/rev/2a286f214c783ff919d802c23a92e54bbf7411b9/browser/app/profile/firefox.js#2042 links to where the most current lists can be found.

It would be good to update the two normal lists in the prefs:

browser.vpn_promo.disallowed_regions
browser.contentblocking.report.vpn_regions

along with all three lists in BrowserUtils.sys.mjs

Comment 1

[Hanna Alemu [:hanna_a]]

Hi @dmose, which list is more accurate (which should we update the prefs and lists to?) -> There's 33 supported regions listed on the moz.org site and there are 44 regions listed on the bedrock github

Also noticed that 'ua' (ukraine) is in the disallowed list pref but not in the bedrock list, is this ok to keep?

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

For the list accuracy, ask in #mozilla-vpn-marketing, partly because I suspect those should not be different, so it would be good if marketing found out about it.

I don't know what the current theory about 'ua' is, but I suspect it's changed since it was first implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1741741#c12.

I'd start by reaching out to mfeldman from Legal. That said, if there's not a quick answer, I think it would be fine to leave it in place for now (since that's the more conservative plan and doesn't change current behavior) and spin off a separate bug to handle what to do about Ukraine.

Comment 3

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1858584 - update region lists for deciding whom to show VPN promos to r=dmose

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a53c4356e8d1
update region lists for deciding whom to show VPN promos to r=omc-reviewers,dmose

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a53c4356e8d1

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task and I can confirm that the VPN Promo is displayed on the "about:preferences#moreFromMozilla" page if the browser region is set to one of the following: bg,cy,cz,dk,ee,hr,hu,je,lu,lt,lv,mt,pl,pt,ro,si,sk.

Verified using the latest Firefox Nightly 121.0a1 (Build ID: 20231115214519) installed on Windows 10 x64, macOS 14.1.1, and Ubuntu 22.04 x64.