Closed Bug 185873 Opened 20 years ago Closed 20 years ago

printing prettyprinted page only prints first page

Categories

(Core :: XML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.4alpha

People

(Reporter: sicking, Assigned: hjtoi-bugzilla)

Details

Attachments

(1 file, 1 obsolete file)

When printing a prettyprinted page only the first page is printed. This is
probably due to the fact that the prettyprint content is inside an

<div style="top: 0; bottom: 0; left: 0; right: 0;">

This might be fixable by having an "@media print" rule that does some cool
css-trick.
I have also seen this problem while looking at XML schemas, which are themselves
XML documents.
An entire XML that has no stylesheet is displayed nicely as a color enhanced
document tree.  However an attempt to print only gets the first page, and print
preview always says Page 1 of 1.  Selecting File, Print, Print Range, All, or
even File, Print, Print Range, Pages, From 1 to (say) 10, does not help.  It
still only prints the first page.
Attached patch Possible fix (obsolete) — Splinter Review
This change makes printing work.

Jonas, why is the style rule like that for #top, it seems weird to me?
Whiteboard: [fixinhand]
Target Milestone: --- → mozilla1.4alpha
Comment on attachment 116894 [details] [diff] [review]
Possible fix

You should be able to remove that thing entierly. I wanted to protect against
styling on the root element, but that's silly considering that if there is any
styling we won't prettyprint in the first place.
Attachment #116894 - Flags: review-
Attachment #116978 - Flags: superreview?(peterv)
Attachment #116978 - Flags: review?(bugmail)
Comment on attachment 116978 [details] [diff] [review]
removed #top rule, seems to work equally well

r=sicking. Thanks for doing this!
Attachment #116978 - Flags: review?(bugmail) → review+
Attachment #116978 - Flags: superreview?(peterv) → superreview+
Checked in.
Whiteboard: [fixinhand]
This was fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.