1858762 - Sidebar animation on expand/collapse

Status: RESOLVED WONTFIX

(Firefox :: Shopping, enhancement, P2)

Description

[Ania]

Right now, there's no animation for expanding or collapsing the sidebar.

Let's please start working on the animation that would smooth out it, as closely as it is reasonable to Julian's prototype - https://jwels.berlin/shopping/

Comment 1

[kpatenio]

Attachment: Bug 1858762 - add animation on sidebar expand/collapse

Comment 3

[wrocklin]

Can I get an update on this one. How are we looking? Is this something we expect to finish in the next week? Given soft code freeze has elapsed for v121, would we uplift this or just move to v122?

Comment 4

[kpatenio]

(In reply to wrocklin from comment #3)

Can I get an update on this one. How are we looking? Is this something we expect to finish in the next week? Given soft code freeze has elapsed for v121, would we uplift this or just move to v122?

Hi Will, Gijs and I briefly talked and agreed that it should be okay to uplift. I'm expecting to get this finished in the next week.

Comment 5

[wrocklin]

Thanks for the update. I won't stop an uplift : ) Thank you!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cad4a7cf7a1b
add animation on sidebar expand/collapse r=desktop-theme-reviewers,shopping-reviewers,dao,Gijs

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_shopping_integration.js

Backout link

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8ed01f5f4e3
add animation on sidebar expand/collapse r=desktop-theme-reviewers,shopping-reviewers,dao,Gijs

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b8ed01f5f4e3

Comment 10

[kpatenio]

Comment on attachment 9362254 [details]
Bug 1858762 - add animation on sidebar expand/collapse

Beta/Release Uplift Approval Request

• User impact if declined: Users won't see an animation when closing or opening the shopping sidebar, which appears on supported product pages (amazon.com, walmart.com, bestbuy.com). It will only affect users that are exposed to the review checker experience.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is relatively low risk to uplift since the changes are for visual styling/animation purposes and do not affect overall functionality of the sidebar.
• String changes made/needed:
• Is Android affected?: No

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9362254 [details]
Bug 1858762 - add animation on sidebar expand/collapse

Approved for 121.0b5.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7ec919f740b9

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly as well as our latest Beta 121.0b5.

Comment 14

[Cosmin Sabou [:CosminS]]

Backed out from 121.0b6 as requested by jhirsch.
Backout link: https://hg.mozilla.org/releases/mozilla-beta/rev/8e00ed90450f29ee0286348a831fc0980397f8e7

Comment 15

[Cosmin Sabou [:CosminS]]

Backed out also from 122 as requested by jhirsch.
Backout link: https://hg.mozilla.org/integration/autoland/rev/9d2831e8fb6f07970d725c286f8b156512ba6d5a
Setting wontfix as Jared mentioned on matrix.

Comment 16

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/9d2831e8fb6f