1858851 - Dashed dates with alphabetic month names and year > 9999 parse incorrectly

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect, P3)

Description

[Vinny Diehl]

The year is parsed as a negative.

> eshost -te 'new Date("01-Jan-10000").toString()'

Engine	Result
JavaScriptCore	Sat Jan 01 10000 00:00:00 GMT-0700 (Mountain Standard Time)
SpiderMonkey	Sat Jan 01 -10000 00:00:00 GMT-0728 (Mountain Standard Time)
V8	Sat Jan 01 10000 00:00:00 GMT-0700 (Mountain Standard Time)

This presents similarly to bug 1617562, because the format is being rejected by TryParseDashedDatePrefix; some trivial adjustments to make it accept 5- and 6-digit years should fix this.

Comment 1

[Vinny Diehl]

Attachment: Bug 1858851 - Fix parsing for dashed dates with alphabetic month and year > 9999 r?arai

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00c1813123fd
Fix parsing for dashed dates with alphabetic month and year > 9999 r=arai

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for SM failures on dashed-date.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=00c1813123fd4ca7ec1446ebdabe2848814e550e&selectedTaskRun=fEc2RkNOSaG5SzqnDuAlgg.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=433455333&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=433463477&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/7b2d6b3b2f1aee8ffc913c56f98a4185526781e3

Comment 4

[Vinny Diehl]

This was overflowing s on opt builds, fixed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36a87a643270
Fix parsing for dashed dates with alphabetic month and year > 9999 r=arai

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/36a87a643270

Comment 7

[Vinny Diehl]

Relnoted here: https://github.com/mdn/content/pull/30234