1858932 - The VSCode build task fails to run

Status: RESOLVED FIXED

(Developer Infrastructure :: Developer Environment Integration, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Running the default build task by Control+Shift+B says:

 *  Executing task: /mozilla-build/start-shell.bat cd "$('C:\Users\sasch\Documents\GitHub\gecko-dev' -replace '\\','/')" ';' mach --log-no-times build binaries 

MozillaBuild Install Directory: C:\mozilla-build\
/usr/bin/bash: cd: No such file or directory

 *  The terminal process "C:\Users\sasch\AppData\Local\Microsoft\WindowsApps\Microsoft.PowerShell_8wekyb3d8bbwe\pwsh.exe -Command /mozilla-build/start-shell.bat cd "$('C:\Users\sasch\Documents\GitHub\gecko-dev' -replace '\\','/')" ';' mach --log-no-times build binaries" terminated with exit code: 1. 
 *  Terminal will be reused by tasks, press any key to close it. 

Modifying the task definition this way works if the user has installed Python:

    "windows": {
      "command": "./mach.ps1",
      "args": [
        "--log-no-times"
      ]
    },

But not if they have no Python in PATH. We could fallback to MozillaBuild python if there's no python, but simply checking whether there's python doesn't work as Microsoft by default exposes dummy python executable for no good reason.

But it's already broken, maybe breaking it in another way by requiring python shouldn't harm.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1858932 - Skip bash and run mach directly on powershell for tasks.json r=tcampbell

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08072f3d2801
Skip bash and run mach directly on powershell for tasks.json r=tcampbell DONTBUILD

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/08072f3d2801