1858937 - Perma devtools/server/tests/chrome/test_inspector-inactive-property-helper.html | text-wrap: balance; is inactive when line number exceeds threshold when Gecko 120 merges to Beta on 2023-10-23

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Natalia Csoregi [:nataliaCs]]

• Central-as-beta-simulation
• How to run these simulations
• Failure log

[task 2023-10-13T11:39:26.733Z] 11:39:26     INFO - TEST-PASS | devtools/server/tests/chrome/test_inspector-inactive-property-helper.html | text-wrap: balance; is active when line number is below threshold 
[task 2023-10-13T11:39:26.733Z] 11:39:26     INFO - GECKO(3174) | [Parent 3174, Main Thread] WARNING: 'sheet->HasModifiedRules()', file /builds/worker/checkouts/gecko/layout/style/Loader.cpp:1673
[task 2023-10-13T11:39:26.734Z] 11:39:26     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-10-13T11:39:26.735Z] 11:39:26     INFO - TEST-UNEXPECTED-FAIL | devtools/server/tests/chrome/test_inspector-inactive-property-helper.html | text-wrap: balance is inactive when element is fragmented 
[task 2023-10-13T11:39:26.735Z] 11:39:26     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:426:16
[task 2023-10-13T11:39:26.735Z] 11:39:26     INFO - @chrome://mochitests/content/chrome/devtools/server/tests/chrome/test_inspector-inactive-property-helper.html:110:7
[task 2023-10-13T11:39:26.736Z] 11:39:26     INFO - async*@chrome://mochitests/content/chrome/devtools/server/tests/chrome/test_inspector-inactive-property-helper.html:118:3
[task 2023-10-13T11:39:26.736Z] 11:39:26     INFO - GECKO(3174) | [Parent 3174, Main Thread] WARNING: 'sheet->HasModifiedRules()', file /builds/worker/checkouts/gecko/layout/style/Loader.cpp:1673
[task 2023-10-13T11:39:26.737Z] 11:39:26     INFO - TEST-PASS | devtools/server/tests/chrome/test_inspector-inactive-property-helper.html | text-wrap: initial; is active 

Jonathan, can you look into this, please?
Thank you!

Comment 1

[Jonathan Kew [:jfkthame]]

This test just landed in bug 1851756. I suspect the inactive-property-helper/text-wrap.mjs file (or the test manifest) needs to ensure the feature is preffed-on before trying to test it.

Comment 2

[Sebastian Zartner [:sebo]]

Attachment: Bug 1858937 - [devtools] Enable preference layout.css.text-wrap-balance.enabled in tests for inactive CSS in DevTools. r=jfkthame

Comment 3

[Sebastian Zartner [:sebo]]

(In reply to Jonathan Kew [:jfkthame] from comment #1)

This test just landed in bug 1851756. I suspect the inactive-property-helper/text-wrap.mjs file (or the test manifest) needs to ensure the feature is preffed-on before trying to test it.

Good point for explicitly preffing the feature on for testing. So I did that now.
Though I am wondering a little because the feature is preffed on by default in Nightly. So I am wondering, is there another test that sets it to false and doesn't reset it afterwards? Or is that part of the test config?

Sebastian

Comment 4

[Jonathan Kew [:jfkthame]]

No, you're perfectly correct that it's preffed on by default in Nightly. But the failure here was reported for a Beta simulation: when Nightly is merged to beta, the pref on the beta builds will default to off, and the test then fails.

Comment 5

[Sebastian Zartner [:sebo]]

Ah, totally missed that even when it's already mentioned in the initial comment.

Sebastian

Comment 6

[Narcis Beleuzu [:NarcisB]]

The patch is working in today's late beta simulation

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f99c563251e
[devtools] Enable preference layout.css.text-wrap-balance.enabled in tests for inactive CSS in DevTools. r=devtools-reviewers,nchevobbe

Comment 8

[Sebastian Zartner [:sebo]]

Fantastic! I've pushed the patch to Lando.

Sebastian

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3f99c563251e