1859026 - Investigate if a test of #identity-permission-box in Desktop UI is a non-user-facing and needs to be excluded from a11y_checks

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[Anna Yeddi [:ayeddi]]

There are 2 failing tests for the #identity-permission-box that appear to test not user-facing behavior: the test is sending a click to box.identity-box-button while it is visually hidden with display:none; and it aims to confirm there are no more permissions left for this site. This test target appears to be not done by a user and it does not have to confirm the accessibility of this control.

a11y_checks failing data:

FAIL	"browser/base/content/test/permissions/browser_permissions.js

The click is sent to a display:none element (or while visibility of the permissions toolbarbutton is being changed)"	Node is not accessible via accessibility API	identity-permission-box	box	identity-box-button	"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochitests/content/browser/browser/base/content/test/permissions/head.js:openPermissionPopup:17
chrome://mochitests/content/browser/browser/base/content/test/permissions/browser_permissions.js:testMainViewVisible/<:63
resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
chrome://mochitests/content/browser/browser/base/content/test/permissions/browser_permissions.js:testMainViewVisible:26
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"
FAIL	"browser/base/content/test/permissions/browser_site_scoped_permissions.js

The click is sent to a display:none element (or while visibility of the permissions toolbarbutton is being changed)"	Node is not accessible via accessibility API	identity-permission-box	box	identity-box-button	"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:342
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:659
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:638
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:741
chrome://mochitests/content/browser/browser/base/content/test/permissions/head.js:openPermissionPopup:17
chrome://mochitests/content/browser/browser/base/content/test/permissions/browser_site_scoped_permissions.js:testSiteScopedPermissionSubdomainAffectsBaseDomain/<:49
resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
chrome://mochitests/content/browser/browser/base/content/test/permissions/browser_site_scoped_permissions.js:testSiteScopedPermissionSubdomainAffectsBaseDomain:24
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1859026 - Disable a11y_check for two non-user-facing tests of #identity-permission-box in Desktop UI. r=mconley!,florian,Jamie

We intentionally turn off a11y_checks, because these tests are expected to click a toolbar button that may be already hidden with "display:none;". This test target is not meant to be done by a user and could be inaccessible

Thus, we are excluding this click event from accessibility checks and removing the fail-if annotation that was added by bug 1854228 and bug 1858037 before the investigation in the meta bug 1854233.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6ee9b37c547
Disable a11y_check for two non-user-facing tests of #identity-permission-box in Desktop UI. r=Jamie,mconley

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f6ee9b37c547

Comment 4

[Anna Yeddi [:ayeddi]]

Another intermittent failure is happening with the https://searchfox.org/mozilla-central/rev/9013524d23da6523a7ec4479b5682407a1323f6c/browser/base/content/test/permissions/browser_site_scoped_permissions.js#101 - the environment was set up on the previous test case with the same reason.

Example in the log: https://treeherder.mozilla.org/logviewer?job_id=445496373&repo=autoland&lineNumber=3337

Comment 5

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1859026 - Pt 2. Disable a11y_check for one non-user-facing test of #identity-permission-box in Desktop UI. r=mconley!

We intentionally exclude this click from the a11y_check, because this test case (as the ones in part 1 patch D190979) is expected to click a toolbar button that may be already hidden with "display:none;". The permissions panel anchor is hidden because the last permission was removed, however we force opening the panel anyways in order to test that the list has been properly emptied.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eeb5df11b720
Pt 2. Disable a11y_check for one non-user-facing test of #identity-permission-box in Desktop UI. r=mconley

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/eeb5df11b720