1859243 - Use latest version of Babel in the parser worker

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

We are using some old version of Babel in the parser worker.
I've seen on Github that some performance fixes have landed after our currently used version.
Unfortunately... migrating to the latest doesn't seem to bring any visible improvement on DAMP:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=d2b138c9dec0dc920115272992b9762a9b432218&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=e7bddc6bd6b0a5af5ddf9dff0d8e9fece7cde6ef&page=1&filter=pretty&showOnlyConfident=1

But let's try to bump the version anyway. May be on some other STR it can improve performance.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1859243 - [devtools] Bump babel versions used by the parser worker.

Also removing "buffer", which looks unused.

Comment 2

[Alexandre Poirot [:ochameau]]

For some reason the babel upgrade introduces some failure, but only on try:
https://treeherder.mozilla.org/logviewer?job_id=432594049&repo=try&lineNumber=5498
I'm unable to reproduce locally, even when clearing yarn cache as well as node_modules.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e015d8116f7
[devtools] Bump babel versions used by the parser worker. r=devtools-reviewers,bomsy

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3e015d8116f7

Comment 5

[Julian Descottes [:jdescottes]]

== Change summary for alert #40041 (as of Wed, 25 Oct 2023 17:44:21 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
13%	damp custom.jsdebugger.open-large-minified-file.full-selection.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	5,264.73 -> 4,586.80
11%	damp custom.jsdebugger.open-large-minified-file.full-selection.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	5,090.78 -> 4,518.48
7%	damp custom.pretty-print.jsdebugger.reload.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	10,992.01 -> 10,256.27
7%	damp custom.jsdebugger.pretty-print.reload-and-pause.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	11,201.09 -> 10,461.25
6%	damp custom.pretty-print.jsdebugger.reload.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	10,699.88 -> 10,090.90
...	...	...	...	...
2%	damp custom.jsdebugger.open-large-minified-file.full-selection.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	4,293.98 -> 4,189.76

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40041

Comment 6

[Alexandre Poirot [:ochameau]]

Oh. Before addressing the try failure, DAMP reported no improvements. I did not push again to try with the latest revision, but I confirm that improvements are reported:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=d349f5bc88461cb8be7c9c2134b0157f133f76f5&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=9a3b74c7f40ec003914c697e22d2acc0f16d7ac7&page=1&showOnlyConfident=1