Closed Bug 1859292 Opened 1 year ago Closed 1 year ago

GenericPrinter::vprintf no longer short-circuit after the lack of interpolation.

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox118 --- unaffected
firefox119 --- unaffected
firefox120 --- fixed

People

(Reporter: nbp, Assigned: nbp)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

After Bug 1839396 part 13, which made printer function infallible, the vprintf function prints the content of the string twice if there is no % character in the string to be interpolated.

The problem comes from the removal of the return statement which prevented going to the generic code path.

https://searchfox.org/mozilla-central/rev/6e5b9a5a1edab13a1b2e2e90944b6e06b4d8149c/js/src/vm/Printer.cpp#95

Set release status flags based on info from the regressing bug 1839396

Going over the content of Bug 1839396 part 13, I was not able to spot any additional error similar to the missing return, only the one in vprintf.

Severity: -- → S4
Priority: -- → P1
Pushed by npierron@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/008bb178c280 Restore GenericPrinter::vprintf expected behaviour for non-interpolating strings. r=jseward
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: