1859346 - Focus ring flashes as a line in the titlebar when dialog appears

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Kestrel]

Attachment: Video of line flashing in titlebar when dialog appears

STR:

1. Enable "Confirm before quitting with Ctrl+Q" on Ubuntu 23.10.
2. Press Ctrl+Q.

Orange/white line flashes at the top of the titlebar before confirmation dialog appears. Colors are the same as a focus ring and is more noticeable with a dark theme.

Occurs with other dialogs as well.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f412f38f5b6c938db981e49c1dea24f36df093f9&tochange=f41311ee4ade08929b1224c893ccf12993d32ead

Regressed by Bug 1811129.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sefeng, since you are the author of the regressor, bug 1811129, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Pascal Chevrel:pascalc]

Kestrel, is that a regression with 23.10 or does it reproduce on 23.04 as well? Also wondering if this is a Linux only regression or cross platform.

Comment 3

[Pascal Chevrel:pascalc]

Can we get QA to reproduce this bug and check if this is Linux only? Thanks

Comment 4

[Kestrel]

I can also reproduce it on Ubuntu 22.04 LTS and Windows 10.

Comment 5

[Sean Feng [:sefeng]]

Attachment: Bug 1859346 - Remove the default focus ring for #window-modal-dialog r=Gijs

This focus ring is not needed and causing confusions. We should
remove this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2de3e783430
Remove the default focus ring for #window-modal-dialog r=desktop-theme-reviewers,dao

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d2de3e783430

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sefeng, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Sean Feng [:sefeng]]

I don't think this is a huge issue that needs an uplift, I'll just let it ride the train.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 119.0 on Ubuntu 22.
Verified as fixed on Firefox 120.0b4 and Nightly 121.0a1 on Ubuntu 22, Windows 10, macOS 12.