1859414 - IsPrivilegedMozillaRemoteType is unused

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P3)

Description

[Andrew McCreight [:mccr8]]

It looks like this method was added in bug 1657188 for use in nsDOMNavigationTiming::MaybeSubmitTimeToLoadEventPreloadTelemetry(), but that method no longed exists, so IsPrivilegedMozillaRemoteType is now unused.

Comment 1

[Jens Stutte [:jstutte]]

It looks in general like we have a mixture of using the types directly like here and having the concurrent IsXXXType functions for some of them, all rarely used IIUC. I can see some value to wrap those that need a StringBeginsWith, but then I'd probably recommend to have them all and use them always.

Comment 2

[ChaseKnowlden]

Attachment: Bug 1859414 - [ipc] Remove IsPrivilegedMozillaRemoteType. r=jstutte!

Comment 3

[Jens Stutte [:jstutte]]

(In reply to Jens Stutte [:jstutte] from comment #1)

It looks in general like we have a mixture of using the types directly like here and having the concurrent IsXXXType functions for some of them, all rarely used IIUC. I can see some value to wrap those that need a StringBeginsWith, but then I'd probably recommend to have them all and use them always.

Moved this to bug 1861397, in the meantime removing unused code is always good.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b898dedc56c
[ipc] Remove IsPrivilegedMozillaRemoteType. r=jstutte

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2b898dedc56c