Closed
Bug 1859561
Opened 2 years ago
Closed 2 years ago
Glinter should capture empty strings or `TODO` markers in data_review
Categories
(Data Platform and Tools :: Glean: SDK, defect, P1)
Data Platform and Tools
Glean: SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: janerik, Assigned: janerik)
Details
Attachments
(1 file)
|
[mozilla/glean_parser] Bug 1859561 - Warn about empty or TODO-tagged data reviews in the list (#635)
48 bytes,
text/x-github-pull-request
|
Details | Review |
Right now the data_reviews list is required, but it's easy to work around: put in TODO or even the empty string ('') and it will be happy.
At least a warning on these invalid values might be a good idea.
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → jrediger
Priority: P3 → P1
|
||
Comment 1•2 years ago
|
||
|
|
Assignee | |
Updated•2 years ago
|
Whiteboard: [telemetry:glean-rs:m?]
|
|
Assignee | |
Comment 2•2 years ago
|
||
badboy merged PR [mozilla/glean_parser]: Bug 1859561 - Warn about empty or TODO-tagged data reviews in the list (#635) in 693cd95.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•