Closed Bug 1859585 Opened 6 months ago Closed 5 months ago

Unable to see the settings option after installing an add-on from AMO

Categories

(Fenix :: WebExtensions, defect, P1)

All
Android

Tracking

(firefox119 wontfix, firefox120 wontfix, firefox121 fixed)

RESOLVED FIXED
121 Branch
Tracking Status
firefox119 --- wontfix
firefox120 --- wontfix
firefox121 --- fixed

People

(Reporter: amejia, Assigned: rpl)

References

Details

(Whiteboard: [addons-jira] )

Attachments

(4 files, 1 obsolete file)

STR

  1. Install an add-on from the AMO website.
  2. Go to settings -> add-ons -> tap on the installed add-on.

Expected behaviour.

At step 2 , the "Settings" option should be visible.

Actual behaviour.

At step 2 , the "Settings" option is hidden, and only shown after restarting Fenix .

Hi Arturo, can you please clarify why this was nominated for tracking status?

Flags: needinfo?(amejiamarmol)
Severity: S1 → S4
Flags: needinfo?(amejiamarmol)
Priority: P3 → --

(In reply to Ryan VanderMeulen [:RyanVM] from comment #1)

Hi Arturo, can you please clarify why this was nominated for tracking status?

Sorry, the priority was incorrect I updated it.

Assignee: nobody → amejiamarmol
Status: NEW → ASSIGNED
Priority: -- → P1

This patch includes the following changes:

  • A new AddonManagerDelegate.onReady delegated method: this new delegated method is expected to be called when an extension
    has been started.
    On the firefox-android's android-components side (in particular the components providing the building blocks used by the
    Fenix AddonManager UI) are meant to be using this new delegated method to make sure that the resolved optionsPageUrl will
    be stored in the installedExtension map kept on the android-components side (by the WebExtensionSupport class to be precise),
    as a side-effect of that the settings button in the addon detail view is expected to become visible after having
    installed a new extension from AMO (as it was already the case for addons installed from the recommended set directly from
    the Fenix Addon Manager).

  • Removes the implicit await on the extension to be ready from the underlying logic handling on the Gecko side the calls to
    the WebExtensionController.install method (which before these changes was the hack meant to make sure the settings button
    would be visible after installing an addon from the Fenix AddonManager UI).

  • Replaces the previous test case asserting that the optionsPageUrl was going to be available right after having installed
    the extension (which was working only thanks to the implicit await described right above) with a test case covering the
    new expected behavior.

NOTE: To fully fix the issue tracked by this bugzilla ticket, this change has to be complemented with some more changes on the
firefox-android github repo side, in particular the once included in this draft patch:

New push to try (for the last round of updates applied on the patch attached in comment 4, to handle test failures caught in the previous push to try linked in comment 5):

Attachment #9361445 - Attachment is obsolete: true
Assignee: amejiamarmol → lgreco

Added leave-open keyword, so that we can then explictly mark this as closed once the github PR is also merged on the firefox-android github repo side.

Keywords: leave-open
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/820f519a2604
Add a new onReady delegated method to the GeckoView AddonManagerDelegate. r=amejiamarmol,willdurand,owlish

Authored by https://github.com/rpl
https://github.com/mozilla-mobile/firefox-android/commit/a9db74712946025a84fbc8c980ededd8c9fc5728
[main] Bug 1859585 - WebExtensionSupport should update installExtensions entries on AddonManagerDelegate.onReady calls.

Both the change to be landed to mozilla-central and the one to be landed in the firefox-android github repo have been merged, the two remainig patches are docs only or not strictly related to the issue tracked by this issue and so we can move them in a separate followup if they are not going to land today or tomorrow. In the meantime we can close this issue as fixed (and proceed with qe verify it if we want to in addition to the quick manual testing Arturo and I did before these patches have been merged).

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch

The patch landed in nightly and beta is affected.
:rpl, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(lgreco)
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/6ece09208fd4
Update GeckoView changelog and docs to mention changes to expectated behaviors on calls to WebExtensionController.install. r=willdurand,owlish,amejiamarmol
https://hg.mozilla.org/integration/autoland/rev/d83157544cf9
Fix build errors on building GeckoView messaging_example and port_message_example. r=willdurand,owlish,amejiamarmol
Flags: needinfo?(lgreco)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: