1859644 - Don't show the full keyword in Firefox Suggest suggestion titles on Android

Status: RESOLVED FIXED

(Fenix :: Search, enhancement)

Description

[Tif Tran]

On Android, FxSuggestSuggestionProvider interpolates the full keyword into the suggestion title, here: https://github.com/mozilla-mobile/firefox-android/blob/ecbf4f6fa5221d4ed0cad35a5a847ee6a9ae2243/android-components/components/feature/fxsuggest/src/main/java/mozilla/components/feature/fxsuggest/FxSuggestSuggestionProvider.kt#L76

We've decided not to show the full keyword for suggestions on mobile for now, so let’s update our implementation and tests to reflect that.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1859644 - Don't show full keyword in FxSuggest Suggesions (#4123)

Comment 2

[BMO Github Automation]

Authored by https://github.com/tiftran
https://github.com/mozilla-mobile/firefox-android/commit/bd9a7c4045da8b61acc50b8f8ee026616c7e1c55
[main] Bug 1859644 - Don't show full keyword in FxSuggest Suggesions

Comment 3

[Lorand Janos]

Hi!
Could we get some STR or scenarios to check to know what and how exactly needs to be tested here?
Thank you!

Comment 4

[Tif Tran]

Hi!
We used to have the query as part of the suggestions, so before if someone where to search for "bmazin" the Suggestion would read "bmazin - Amazon.com Official Site". "bmazin" would now be removed from the suggestion.

Comment 5

[Lorand Janos]

Verified as fixed on the latest Beta build (120.0b5).
Device used: Xiaomi Redmi Pad SE (Android 12).
Marking the ticket as verified for 120.