1859728 - riscv64: fix some failures relating to misuses of BlockTrampolinePoolScope / AssemblerBufferWithConstantPools

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Julian Seward [:jseward]]

Bug 1846474 - Part 4 (680413:44a8e6272cad) made AutoForbidPoolsAndNops nestable
and added some assertions. The riscv64 ports fails those assertions, due to some
not-quite-right uses of BlockTrampolinePoolScope. This patch fixes those uses.

Comment 1

[Julian Seward [:jseward]]

Attachment: bug1859728-riscv-BTPS.diff-1 (WIP patch)

Comment 2

[Julian Seward [:jseward]]

Attachment: Bug 1859728 - riscv64: fix some failures relating to misuses of BlockTrampolinePoolScope / AssemblerBufferWithConstantPools. r=nbp.

Part 4 of Bug 1846474 (680413:44a8e6272cad) made AutoForbidPoolsAndNops
nestable and added some assertions. The riscv64 ports fails those assertions,
due to some not-quite-right uses of BlockTrampolinePoolScope. This patch
fixes those uses.

There are also two simple ridealongs:

• jit/riscv64/Simulator-riscv64.cpp: fix two unhandled function call types

• wasm/WasmSummarizeInsn.cpp: fix compilation errors in the riscv
  implementation of SummarizeTrapInstruction. TrapSite checking isn't enabled
  on riscv yet, and this code might not work as-is, but we should at least
  make it compile.

All of the changes are for riscv64-specific code only.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afe375a5bb0a
riscv64: fix some failures relating to misuses of BlockTrampolinePoolScope / AssemblerBufferWithConstantPools.  r=nbp.

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/afe375a5bb0a