1859776 - Circle CI should not try to push to Docker Hub for PR builds

Status: RESOLVED FIXED

(Socorro :: Antenna, defect)

Description

[Sven Marnach :sven]

When opening a PR from a feature branch directly on the Antenna repo, the Circle CI workflow tries to upload an image to Docker Hub even before the PR is reviewed or merged.

And example build where this happened is https://app.circleci.com/pipelines/github/mozilla-services/antenna/812/workflows/343d89a5-36da-46a8-ab25-fd6389684f7c/jobs/2362

We should probably only upload an image on tagged builds.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

It needs to upload an image in two cases:

1. after a change from a PR has been merged into the main branch -- this triggers a stage deploy
2. after someone has pushed a tag -- this triggers a prod deploy

In this case, because the PR is based on a branch that's in the main repository, CIRCLE_BRANCH is not "main" so it goes into the tag scenario, but there's no tag so it fails. I think we just need to fix that one case.

Comment 2

[Sven Marnach :sven]

OK, makes sense. I hadn't looked at the workflow definition too closely yet. And I'm glad to hear that all changes merged to main immediately go to stage.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

We haven't had a chance to talk about server environments, deploy pipelines, etc. That's on me. We'll get there!

Comment 4

[Sven Marnach :sven]

Attachment: [mozilla-services/antenna] bug 1859776: prevent Docker Hub upload script from crashing for non-main branch builds. (#947)

Comment 5

[Sven Marnach :sven]

smarnach merged PR [mozilla-services/antenna]: bug 1859776: prevent Docker Hub upload script from crashing for non-main branch builds. (#947) in 32e24d0.