Closed Bug 1859793 Opened 1 year ago Closed 1 year ago

[Experiment] The "PDF_HANDLER_ANNOTATIONS" message from the Treatment A branch of the "Set Default PDF Handler with Annotations" experiment is not blocked if the "Set as Default" button is clicked

Categories

(Firefox :: Messaging System, defect, P1)

Desktop
Windows
defect

Tracking

()

VERIFIED FIXED
Iteration:
121.1 - Oct 23 - Nov 3
Tracking Status
firefox118 --- verified
firefox119 --- verified

People

(Reporter: mcoman, Assigned: jprickett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached image rec of the issue 2.gif

[Notes]:

  • We have observed in the experimenter ticket that the following part of the JSON that is contained in the "Treatment B" branch value is not present in the "Treatment A" branch value for the Set as Default action:
    { "type": "BLOCK_MESSAGE", "data": { "id": "PDF_HANDLER_ANNOTATIONS:treatment_a" }

[Affected versions]:

  • Firefox Release 118.0.2 - Build ID: 20231009140911
  • Firefox RC 119.0 - Build ID: 20231013091412

[Affected Platforms]:

  • Windows 10 x64

[Prerequisites]:

  • Have a Firefox profile with the following prefs in the "about:config" page:
    • nimbus.debug set to true
    • browser.newtabpage.activity-stream.asrouter.devtoolsEnabled set to true

[Steps to reproduce]:

  1. Open the browser with the profile from the prerequisites.
  2. Navigate to "about:studies?optin_slug=set-default-pdf-handler-with-annotations&optin_branch=treatment-a&optin_collection=nimbus-preview".
  3. Navigate to the "about:newtab#devtools" page and search for the "PDF_HANDLER_ANNOTATIONS:treatment_a" message.
  4. Click the "Show" button from the message section.
  5. Click the "Set as Default" button from the "PDF Handler".
  6. Observe the message from the "AS Router Admin"

[Expected result]:

  • The message section is grayed out and the "Unblock" button is displayed.

[Actual result]:

  • Nothing happens, the message remains active.

[Additional Notes]:

  • Due to this issue the message will be redisplayed to users if the default PDF handler is changed to another known browser.
  • This issue is not reproducible with the Treatment B branch of the experiment. The "PDF_HANDLER_ANNOTATIONS:treatment_b" is blocked if the "Set as Default" button is clicked.
  • Attached a screen recording of the issue.
Assignee: nobody → jprickett
Status: NEW → ASSIGNED
Iteration: --- → 121.1 - Oct 23 - Nov 3
Priority: -- → P1

This was due to the primary button action of treatment-A being misconfigured. The issue has been addressed.

I have verified that this issue is no longer reproducible using the latest Firefox Release 119.0 (Build ID: 20231019122658) and the latest Firefox Beta 120.0b1 (Build ID: 20231023135443) installed on Windows 10 x64. I can confirm that the "PDF_HANDLER_ANNOTATIONS" message from the Treatment A branch of the "Set Default PDF Handler with Annotations" is blocked if the "Set as Default" button is clicked.

Considering the above I am closing this issue as Resolved - Fixed.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Marking as Verified based on comment 2.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: