1859794 - [Experiment] The "PDF_HANDLER_ANNOTATIONS" message from the Treatment A branch of the "Set Default PDF Handler with Annotations" is not blocked if the "X" button is clicked

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Notes]:

• We have observed in the experimenter ticket that the id from the "dismiss_button" area of the PDF Handler message value from Treatment A is set to "NEWTAB_POCKET_TOPICS_SURVEY" instead of "PDF_HANDLER_ANNOTATIONS:treatment_a".

[Affected versions]:

• Firefox Release 118.0.2 - Build ID: 20231009140911
• Firefox RC 119.0 - Build ID: 20231013091412

[Affected Platforms]:

• Windows 10 x64

[Prerequisites]:

• Have a Firefox profile with the following prefs in the "about:config" page:
  • nimbus.debug set to true
  • browser.newtabpage.activity-stream.asrouter.devtoolsEnabled set to true

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to "about:studies?optin_slug=set-default-pdf-handler-with-annotations&optin_branch=treatment-a&optin_collection=nimbus-preview".
3. Navigate to the "about:newtab#devtools" page and search for the "PDF_HANDLER_ANNOTATIONS:treatment_a" message.
4. Click the "Show" button from the message section.
5. Click the "X" button from the top-right part of the "PDF Handler".
6. Observe the message from the "AS Router Admin"

[Expected result]:

• The message section is grayed out and the "Unblock" button is displayed.

[Actual result]:

• Nothing happens, the message remains active.

[Additional Notes]:

• Due to this issue the message will be displayed to users each time an URL ending in pdf will be accessed and may harm the user experience.
• This issue is not reproducible with the Treatment B branch of the experiment. The "PDF_HANDLER_ANNOTATIONS:treatment_b" is blocked if the "X" button is clicked.
• Attached a screen recording of the issue.

Comment 1

[Jason Prickett]

This was due to the dismiss action of treatment-A being misconfigured. The issue has been addressed.

Comment 2

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Release 119.0 (Build ID: 20231019122658) and the latest Firefox Beta 120.0b1 (Build ID: 20231023135443) installed on Windows 10 x64. I can confirm that the "PDF_HANDLER_ANNOTATIONS" message from the Treatment A branch of the "Set Default PDF Handler with Annotations" is blocked if the "X" button is clicked.

Considering this I am closing this issue as Resolved - Fixed.

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

Based on comment 2 I am marking this issue as Verified - Fixed.