1859941 - [wpt-sync] Sync PR 42619 - Change expectation for invalid/missing shadowRootMode IDL to null

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42619 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42619
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Change expectation for invalid/missing shadowRootMode IDL to null

Per the spec discussion:

https://github.com/whatwg/html/pull/5465#discussion_r1360590511

this changes the expectation for the tests to be:

document.createElement("template").shadowRootMode === ""

rather than === null.

Note that this CL does not change Chromium's behavior, and as such
I cannot check if there are other tests that implicitly also
do a similar check. More tests might need to change once I (or
someone) implements this new behavior in a browser.

Bug: 1379513
Change-Id: I0ea1371d612d524fdecc287f3f1790d601c64982
Reviewed-on: https://chromium-review.googlesource.com/4954120
WPT-Export-Revision: c45fa7e8a8cccf8f1e4841ccc7669b6ad7c0a6be

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 42619 applied with additional changes from upstream: 6e6d5b9c16edca477916bf2118342160a2fb6243, 17743f761d9f8bd3954bc68c60b88d251f9a2239

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=193e194ca5e15b06cc24dacc4586eb17c69a7ac3

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 15 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 13

Chrome

OK : 1
PASS: 14
FAIL: 1

Safari

OK : 1
PASS: 9
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /shadow-dom/declarative/declarative-shadow-dom-basic.html [wpt.fyi]
  • Declarative Shadow DOM: Basic test: FAIL linked bug:Bug 1676798
  • Declarative Shadow DOM: Feature detection: FAIL linked bug:Bug 1676798
  • Declarative Shadow DOM: Multiple roots: FAIL linked bug:Bug 1676798
  • Declarative Shadow DOM: template containing declarative shadow root: FAIL linked bug:Bug 1676798
  • Declarative Shadow DOM: template containing (deeply nested) declarative shadow root: FAIL linked bug:Bug 1797854
  • Declarative Shadow DOM: template containing a template containing declarative shadow root: FAIL linked bug:Bug 1797854
  • Declarative Shadow DOM: template containing declarative shadow root and UA shadow root: FAIL linked bug:Bug 1676798

New Tests That Don't Pass

• /shadow-dom/declarative/declarative-shadow-dom-basic.html [wpt.fyi]
  • Declarative Shadow DOM: Basic test: FAIL (Chrome: PASS, Safari: PASS)
  • Declarative Shadow DOM: Feature detection: FAIL (Chrome: PASS, Safari: PASS)
  • Shadowrootmode reflection: FAIL (Chrome: FAIL, Safari: FAIL)
  • Declarative Shadow DOM: Fragment parser basic test: FAIL (Chrome: PASS, Safari: FAIL)
  • Declarative Shadow DOM: Invalid shadow root attribute: FAIL (Chrome: PASS, Safari: FAIL)
  • Declarative Shadow DOM: Closed shadow root attribute: FAIL (Chrome: PASS, Safari: FAIL)
  • Declarative Shadow DOM: Missing closing tag: FAIL (Chrome: PASS, Safari: FAIL)
  • Declarative Shadow DOM: delegates focus attribute: FAIL (Chrome: PASS, Safari: FAIL)
  • Declarative Shadow DOM: Multiple roots: FAIL (Chrome: PASS, Safari: PASS)
  • Declarative Shadow DOM: template containing declarative shadow root: FAIL (Chrome: PASS, Safari: PASS)
  • Declarative Shadow DOM: template containing (deeply nested) declarative shadow root: FAIL (Chrome: PASS, Safari: PASS)
  • Declarative Shadow DOM: template containing a template containing declarative shadow root: FAIL (Chrome: PASS, Safari: PASS)
  • Declarative Shadow DOM: template containing declarative shadow root and UA shadow root: FAIL (Chrome: PASS, Safari: PASS)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36bafbbc0d89
[wpt PR 42619] - Change expectation for invalid/missing shadowRootMode IDL to null, a=testonly

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/36bafbbc0d89