1860007 - [wpt-sync] Sync PR 42628 - Fixed FontPalette hash computation

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42628 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42628
Details from upstream follow.

Munira Tursunova <[e-mail]> wrote:

Fixed FontPalette hash computation

FontPalete hash computation didn't take to account interpolable values
and matching_family_name for normal FontPalette was set to non-empty
value in [0]. This was causing DCHECK crash during resizing of the
hash_table while inserting new objects in FontFallbackMap, compare [1].

This change fixes interpolable FontPalette hash computation and insures
that matching_family_name of normal FontPalette is empty.

[0] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_font_selector.cc;l=73?q=ResolveInterpolableFontPalette&sq=&ss=chromium%2Fchromium%2Fsrc
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/fonts/font_fallback_map.cc?q=FontFallbackMap::Get&ss=chromium%2Fchromium%2Fsrc

Bug: 1491006
Change-Id: I26d023fdaea2f3392e9a9e5d067ef9ffb0c3328c
Reviewed-on: https://chromium-review.googlesource.com/4953356
WPT-Export-Revision: 8c7fc3266f9d04c99d8399d969f3756107aa94c9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5939eb3316dd350e756f7c96ecdffa1b907e0835

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
PASS: 2

Chrome

OK : 1
PASS: 2

Safari

OK : 1
PASS: 2

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf71444ad952
[wpt PR 42628] - Fixed FontPalette hash computation, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cf71444ad952