1860290 - Forgot to include brand.ftl in ExtensionsUI.sys.mjs

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[John Bieling (:TbSync)]

The add-on popups now show untranslated { -brand-short-name }

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1860290 - Include brand.ftl in ExtensionsUI.sys.mjs for add-on install popups. r=#thunderbird-reviewers

Comment 2

[John Bieling (:TbSync)]

Attachment: Bug 1860290 - [ESR115] Include brand.ftl in ExtensionsUI.jsm for add-on install popups. r=#thunderbird-reviewers

Comment 3

[John Bieling (:TbSync)]

Just to make sure: The [ESR115] marked version of the patch is for 115.4.0. It needs its own patch, because we recently converted ExtensionsUI.jsm to ExtensionsUI.sys.mjs on comm-central.

Comment 4

[John Bieling (:TbSync)]

Comment on attachment 9359570 [details]
Bug 1860290 - [ESR115] Include brand.ftl in ExtensionsUI.jsm for add-on install popups. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1842490
User impact if declined: Add-on install popup shows { -brand-short-name }
Testing completed (on c-c, etc.): none
Risk to taking this patch (and alternatives if risky): This patch just adds "branding/brand.ftl" to the Localization object. I could not run eslint, but it should be fine.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9359570 [details]
Bug 1860290 - [ESR115] Include brand.ftl in ExtensionsUI.jsm for add-on install popups. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/19c46abc191b

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8374bda2e8fd
Include brand.ftl in ExtensionsUI.sys.mjs for add-on install popups. r=babolivier

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/6666b40a6383