1860360 - Perma /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp:225:24: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-extension]

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=433307684&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ctS9thoZRz-Tk4KhrA0Ktw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o multi_tcp_socket_unittest.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DHAVE_STRDUP -DNR_SOCKET_IS_VOID_PTR -DSCTP_DEBUG -DLINUX -D__Userspace_os_Linux=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/test -I/builds/worker/workspace/obj-build/dom/media/webrtc/transport/test -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/port/linux/include -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/crypto -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/ice -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/util -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/event -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/plugin -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/port/generic/include -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/share -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/stats -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/libekr -I/builds/worker/checkouts/gecko/netwerk/sctp/src -I/builds/worker/checkouts/gecko/xpcom/tests -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/multi_tcp_socket_unittest.o.pp   /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp
[task 2023-10-21T03:19:28.262Z] 03:19:28    ERROR -  /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp:225:24: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-extension]
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -    225 |     char received_data[buflen];
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -        |                        ^~~~~~
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -  /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp:225:24: note: read of non-const variable 'buflen' is not allowed in a constant expression
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -  /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp:224:12: note: declared here
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -    224 |     size_t buflen = expected_len ? expected_len + 1 : 100;
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -        |            ^
[task 2023-10-21T03:19:28.262Z] 03:19:28    ERROR -  /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp:279:24: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-extension]
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -    279 |     char received_data[expected_len + 1];
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -        |                        ^~~~~~~~~~~~~~~~
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -  /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp:279:24: note: function parameter 'expected_len' with unknown value cannot be used in a constant expression
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -  /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp:276:52: note: declared here
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -    276 |   void RecvDataFailed_s(nr_socket* sent_to, size_t expected_len,
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -        |                                                    ^
[task 2023-10-21T03:19:28.262Z] 03:19:28     INFO -  2 errors generated.
[task 2023-10-21T03:19:28.262Z] 03:19:28    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:689: multi_tcp_socket_unittest.o] Error 1

Comment 1

[Narcis Beleuzu [:NarcisB]]

Retriggers are pointing to this merge to central.
Sylvestre, could this be caused by Bug 1860157?

Comment 2

[Intermittent Failures Robot]

6 failures in 3484 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6

Platform and build breakdown:

• linux64: 6
  • opt: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1860360&startday=2023-10-16&endday=2023-10-22&tree=all

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

clang trunk bustages are often unrelated to changes in mozilla-central but caused by changes to clang trunk which is not in mozilla-central.

If backfills also fail, it's a clang trunk issue else it's related to a check-in.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1860360 - Disable -Wvla-cxx-extension warning in clang 18.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64f5c2917a7f
Disable -Wvla-cxx-extension warning in clang 18. r=firefox-build-system-reviewers,andi

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/64f5c2917a7f

Comment 7

[Intermittent Failures Robot]

1 failures in 3657 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• linux64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1860360&startday=2023-10-23&endday=2023-10-29&tree=all