1860443 - nextUnreadThread jumps to next unread message

Status: RESOLVED INVALID

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[aaronliu0130]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

I extracted the source code of https://addons.thunderbird.net/en-US/thunderbird/addon/next-unread-thread/ and changed line 13 to recentWindow.goDoCommand('cmd_nextUnreadThread');. After that, I pressed on the extension's button

Actual results:

However, the extension still goes to the next unread message instead of the collapsed thread despite thread view being enabled and collapsed

Expected results:

The extension would give me the thread view of the collapsed thread

Comment 1

[Magnus Melin [:mkmelin]]

Bug 1847792?

Comment 2

[aaronliu0130]

Hmm, seems like this would have the same fix as https://phabricator.services.mozilla.com/D191740 . I’m a bit confused by that though: looking at the names shouldn’t nextUnreadMsg just go to the next message regardless of threads and only nextUnreadThread alwayss go to the next collapsed thread?

Comment 3

[Hartmut Welpmann [:welpy-cw]]

(In reply to aaronliu0130 from comment #2)

Hmm, seems like this would have the same fix as https://phabricator.services.mozilla.com/D191740 . I’m a bit confused by that though: looking at the names shouldn’t nextUnreadMsg just go to the next message regardless of threads

It does, the comment there explains the special case: "If we're doing next unread, and a collapsed thread is selected, and the top level message is unread, just set the result manually to the top level message ..."

and only nextUnreadThread alwayss go to the next collapsed thread?

Maybe the naming is a bit misleading: It expands the next thread and selects the first unread message in it.

Comment 5

[aaronliu0130]

Is the fix intended to also expand the thread? What I want is for a command to just hover over the next unread collapsed thread when I do things.

Comment 6

[Magnus Melin [:mkmelin]]

See comment 3

Comment 7

[aaronliu0130]

The latest version of Betterbird claims to have shipped the patch already, but the n button now expands the thread while going to the first message. Correct me if I'm wrong, but that appears to be all that was changed. The comment also doesn't mention whether the thread would still be collapsed and it gives me the impression it would still be. Is it intended for it to be expanded? What I want is for it to stay collapsed.

Comment 8

[Magnus Melin [:mkmelin]]

Thunderbird 115.4.3 shipped the patch.
Yes, it's expected for the thread to be expanded.
I'm not sure what you're asking for. Navigating inside a collapsed thread? That would be weird - where would the selection even go?

Comment 9

[aaronliu0130]

I’m asking for it to navigate to the next thread/message, but if it is collapsed, don’t expand it. I find it convenient to look at the collapsed view of a thread as all messages have an overview shown.

Comment 10

[Magnus Melin [:mkmelin]]

Well, the patch didn't change cmd_nextUnreadThread.
Anyway, what an add-on did or did not do with that is not in scope for bugzilla. Add-on issues should be handled by their developers.

Comment 11

[aaronliu0130]

Could this be closed as something other than duplicate then?