Closed Bug 1860509 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 42681 - Implement replace behaviour in InterpolableFontPalette::Add()

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42681 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42681
Details from upstream follow.

Munira Tursunova <moonira@google.com> wrote:

Implement replace behaviour in InterpolableFontPalette::Add()

InterpolableFontPalette::Add() didn't replace the value, which causes
underlying computed style value to be applied instead of computed
interpolable FontPalette value when endpoints keyframes were not
specified.
This change fixes that by implementing replacement behaviour in
InterpolableFontPalette::Add().

Bug: 1491010
Change-Id: I32b40a1b0f0d951fe85c4ff8a3f6816a7ec7b4b0
Reviewed-on: https://chromium-review.googlesource.com/4965600
WPT-Export-Revision: a848f9a1bfc9427ede2a45468d7f8c7e78ddff08

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 114 subtests

Status Summary

Firefox

OK : 2
PASS: 80
FAIL: 36

Chrome

OK : 2
PASS: 113
FAIL: 3

Safari

OK : 2
PASS: 80
FAIL: 36

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-fonts/animations/font-palette-interpolation.html [wpt.fyi]
    • CSS Transitions: property <font-palette> from [light] to [dark] at (-2) should be [light]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [light] to [dark] at (-0.25) should be [light]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [light] to [dark] at (0) should be [light]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [light] to [dark] at (0.3) should be [palette-mix(in oklab, light, dark 30%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [light] to [dark] at (0.6) should be [palette-mix(in oklab, light, dark 60%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [light] to [dark] at (-2) should be [light]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [light] to [dark] at (-0.25) should be [light]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [light] to [dark] at (0) should be [light]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [light] to [dark] at (0.3) should be [palette-mix(in oklab, light, dark 30%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [light] to [dark] at (0.6) should be [palette-mix(in oklab, light, dark 60%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Animations: property <font-palette> from [light] to [dark] at (0.3) should be [palette-mix(in oklab, light, dark 30%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Animations: property <font-palette> from [light] to [dark] at (0.6) should be [palette-mix(in oklab, light, dark 60%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • Web Animations: property <font-palette> from [light] to [dark] at (0.3) should be [palette-mix(in oklab, light, dark 30%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • Web Animations: property <font-palette> from [light] to [dark] at (0.6) should be [palette-mix(in oklab, light, dark 60%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [initial] to [inherit] at (-2) should be [normal]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [initial] to [inherit] at (-0.25) should be [normal]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [initial] to [inherit] at (0) should be [normal]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [initial] to [inherit] at (0.3) should be [palette-mix(in oklab, normal, light 30%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [initial] to [inherit] at (0.6) should be [palette-mix(in oklab, normal, light 60%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [initial] to [inherit] at (-2) should be [normal]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [initial] to [inherit] at (-0.25) should be [normal]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [initial] to [inherit] at (0) should be [normal]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [initial] to [inherit] at (0.3) should be [palette-mix(in oklab, normal, light 30%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [initial] to [inherit] at (0.6) should be [palette-mix(in oklab, normal, light 60%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Animations: property <font-palette> from [initial] to [inherit] at (0.6) should be [palette-mix(in oklab, normal, light 60%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • Web Animations: property <font-palette> from [initial] to [inherit] at (0.6) should be [palette-mix(in oklab, normal, light 60%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [--custom-palette] to [normal] at (-2) should be [--custom-palette]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [--custom-palette] to [normal] at (-0.25) should be [--custom-palette]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions: property <font-palette> from [--custom-palette] to [normal] at (0) should be [--custom-palette]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [--custom-palette] to [normal] at (-2) should be [--custom-palette]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [--custom-palette] to [normal] at (-0.25) should be [--custom-palette]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <font-palette> from [--custom-palette] to [normal] at (0) should be [--custom-palette]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Animations: property <font-palette> from [--custom-palette] to [normal] at (0.3) should be [palette-mix(in oklab, --custom-palette, normal 30%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • Web Animations: property <font-palette> from [--custom-palette] to [normal] at (0.3) should be [palette-mix(in oklab, --custom-palette, normal 30%)]: FAIL (Chrome: PASS, Safari: FAIL)
    • An interpolation to inherit updates correctly on a parent style change.: FAIL (Chrome: PASS, Safari: FAIL)
    • Test additive animations: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/357155596989 [wpt PR 42681] - Implement replace behaviour in InterpolableFontPalette::Add(), a=testonly https://hg.mozilla.org/integration/autoland/rev/93c78b11cbed [wpt PR 42681] - Update wpt metadata, a=testonly
Regressions: 1863353
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Blocks: 1863353
No longer regressions: 1863353
You need to log in before you can comment on or make changes to this bug.