1860643 - Investigate if two test clicks on .brand-logo in Firefox View are mouse-specific alternatives and need to be excluded from a11y_checks

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P3)

Description

[Anna Yeddi [:ayeddi]]

There are 2 failing test cases for the div/img+.brand-logo that appear to test not user-facing behavior: the test cases are sending clicks to brand-logo as a container. This test target appears to be to confirm the feature tour pref change after a custom FEATURE_CALLOUT messages are dismissed by these clicks on a non-actionable element, while there are other ways to dismiss/pass the tour messages that are accessible.

This is not expected or does not have to be done by a user of an assistive technology and it does not have to confirm the accessibility of this element.

a11y_checks failing data:

FAIL
browser/components/firefoxview/tests/browser/browser_feature_callout.js
Node is not accessible via accessibility API
IMG	brand-logo	
"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_feature_callout.js:feature_callout_advance_tour_on_page_click/<:491
resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_feature_callout.js:feature_callout_advance_tour_on_page_click:479
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"

FAIL
browser/components/firefoxview/tests/browser/browser_feature_callout.js
Node is not accessible via accessibility API
DIV	brand-logo	
"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_feature_callout.js:feature_callout_advance_tour_on_page_click/<:495
resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_feature_callout.js:feature_callout_advance_tour_on_page_click:479
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1860643 - Disable a11y_check for two mouse-specific test cases on .brand-logo in Firefox View. r=sfoster,kcochrane,#fxview-reviewers!,Jamie!

There are 2 failing test cases for the div/img with class name brand-logo that appear to test not user-facing behavior: the test cases are sending clicks to brand-logo as a container. This test target appears to be to confirm the feature tour pref change after a custom FEATURE_CALLOUT messages are dismissed by these clicks on a non-actionable element, while there are other ways to dismiss/pass the tour messages that are accessible.

This is not expected or does not have to be done by a user of an assistive technology and it does not have to confirm the accessibility of this element.

Thus, we are excluding these click events from accessibility checks and removing the fail-if annotation from the test manifest that was added by bug 1854625 and meta bug 1858037 before the investigation in the meta bug 1854233.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09e0e5173987
Disable a11y_check for two mouse-specific test cases on .brand-logo in Firefox View. r=kcochrane,Jamie,fxview-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/09e0e5173987