Closed Bug 1860683 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42700 - Deduplicate some WPT.

Categories

(Core :: Storage: Quota Manager, task, P4)

task

Tracking

()

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42700 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42700
Details from upstream follow.

Evan Stade <estade@chromium.org> wrote:

Deduplicate some WPT.

storagemanager-estimate and estimate-indexeddb are more or less the
same tests, the latter having been ported from the former to use
async/await. The former probably should have been deleted when the
latter was introduced.

Since some of the tests are related to IndexedDB and some are not, this
change keeps the IndexedDB tests in the file called estimate-indexeddb
and keeps the basic tests in storagemanager-estimate (with minor
updates).

One wrinkle from the Chromium side is that the behavior of
storageManager.estimate() is not actually specced, and as the Chromium
implementation uses LevelDB, which behaves in mysterious ways, adding
things to the database does NOT always increase the reported usage size.
Both of these tests operate on large things, which typically do increase
usage, however we noticed that for one reason or another, the test that
adds an uninitialized ArrayBuffer starts failing on Windows if
durability is set to relaxed. There are other ways to make the test fail
as well: using a shorter name for the database, or putting small
values, does not reliably increase the reported usage. This is all fine
in the sense that it isn't defined behavior, but it does suggest that
working in this area or on tests of this ilk is a bit of a minefield.
These tests probably should not exist as WPT, at least not until quota
behavior is specced (see https://github.com/whatwg/storage/issues/110).
But it would also be sort of a shame to delete WPT that are passing, so
I've left them in place for now.

Bug: 1489517
Change-Id: I6619f504ce92e428054691ac6bf54a0e14e3ce5f

Reviewed-on: https://chromium-review.googlesource.com/4968659
WPT-Export-Revision: 5ff2fe9f2dc3b0e79023c254ad4748f56383ae27

Component: web-platform-tests → Storage: Quota Manager
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 2 subtests

Status Summary

Firefox

OK : 4
PASS: 6

Chrome

OK : 4
PASS: 6

Safari

OK : 4
PASS: 5
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe8c71b661e3 [wpt PR 42700] - Deduplicate some WPT., a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.