1860705 - Intermittent [TV] accessible/tests/mochitest/events/test_statechange.html | single tracking bug

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=433518417&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/FE7FFh4NRjW9f39pOjUZPg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/FE7FFh4NRjW9f39pOjUZPg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

TEST-OK | accessible/tests/mochitest/events/test_statechange.html | took 2618ms
[task 2023-10-24T00:20:50.114Z] 00:20:50    ERROR - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/events/test_statechange.html | changed preference: security.mixed_content.upgrade_display_content
[task 2023-10-24T00:20:50.114Z] 00:20:50     INFO - TEST-START | Shutdown

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:Jamie, since you are the author of the regressor, bug 1661923, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1661923

Comment 3

[Intermittent Failures Robot]

9 failures in 3657 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• windows11-32-2009-qr: 2
  • debug: 1
  • opt: 1
• windows11-64-2009-qr: 2
  • debug: 1
  • opt: 1
• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1
• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1860705&startday=2023-10-23&endday=2023-10-29&tree=all

Comment 4

[Daniel Holbert [:dholbert]]

bug 1661923 didn't "regress" this (and this isn't an intermittent). bug 1661923 just happened to touch this test and trigger a test-verify run, which revealed this as a preexisting issue with this test.

The preexisting issue here is that this test sets a pref without ever unsetting it (and test-verify checks for that). That pref-tweak is here:
https://searchfox.org/mozilla-central/rev/9c509b8feb28c1e76ad41e65bf9fd87ef672b00f/accessible/tests/mochitest/events/test_statechange.html#21-24

// Disable mixed-content upgrading as this test is expecting an HTTP load
Services.prefs.setBoolPref(
  "security.mixed_content.upgrade_display_content",
  false

This test should probably use one of the pushPref APIs that automatically revert the pref-modification when the test completes.

Comment 5

[Daniel Holbert [:dholbert]]

(clearing affected version flags which were improperly inferred from the supposed-regressor.)

Comment 6

[Daniel Holbert [:dholbert]]

That setBoolPref invocation came from this commit:
https://hg.mozilla.org/mozilla-central/rev/042aa9ec5d10

(That commit added one other setBoolPref call for the same pref in a different test, and it looks like we already fixed that one over in bug 1866585.)

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: Bug 1860705: Use pushPrefEnv instead of setBoolPref in mochitest test_statechange.html. r?eeejay

setBoolPref has a persistent effect for the rest of the test run (potentially
affecting the behavior of other prefs), so we don't want to use
that. This test is currently failing when run in test-verify mode as a result
of this. With pushPrefEnv, the test will properly undo its pref-modification
when it completes.

Note: I'm moving the pref-toggle statement inside of a function so that I can
use the ergonomic await syntax. This is still essentially right at the start
of the test, since doTests is the main function here.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49f61b86d1b7
Use pushPrefEnv instead of setBoolPref in mochitest test_statechange.html. r=eeejay

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/49f61b86d1b7