1860958 - Handle wgpu::Texture::Destroy() correctly

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Texture::Destroy() is implemented as part of Bug 1856787. But it causes the regression Bug 1860921. Texture::Destroy() should be handled correctly

Comment 1

[Sotaro Ikeda [:sotaro]]

Just implementing Texture::Destroy() { Cleanup(); } caused the following crashes.

• https://searchfox.org/mozilla-central/rev/aa189da432fac500242d9374f044947357f7144e/third_party/rust/wgpu-core/src/storage.rs#125
• https://searchfox.org/mozilla-central/rev/aa189da432fac500242d9374f044947357f7144e/third_party/rust/wgpu-core/src/storage.rs#128

jimb, :nical, any ideas on how to implement Texture::Destroy()?

Comment 2

[Nicolas Silva [:nical]]

I suspect that if we run into these crashes it is because Texture::Destroy ended up calling texture_drop on the wgpu side. All of the _drop functions in wgpu are only meant to be used when the last reference to the texture is gone. Generally there are _destroy methods which do some deinitialization but keep the texture registered with a flag marking it as invalid.

Comment 3

[Nicolas Silva [:nical]]

Yeah so I had a look and the situation was as I descried. I'll implement it since I am familiar with it.

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1860958 - Implement Texture::Destroy. r=#webgpu-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e6f2b2e19c6
Implement Texture::Destroy. r=webgpu-reviewers,jimb

Comment 6

[Cristian Tuns]

Backed out for causing build bustages in RefPtr.h

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:54:38: error: member access into incomplete type 'mozilla::webgpu::CommandEncoder'

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d676e8a3a515
Implement Texture::Destroy. r=webgpu-reviewers,jimb

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1861985 & Bug 1865364 for causing bustage due to CommandEncoder.

• backout: https://hg.mozilla.org/integration/autoland/rev/fd0423fbfca05a4f9f87ef6c3393dbd79269335d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b8905730799
Implement Texture::Destroy. r=webgpu-reviewers,jimb

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2b8905730799

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.