Closed Bug 1861042 Opened 2 years ago Closed 2 years ago

'duration' can be `null` in errorsummary file

Categories

(Testing :: General, defect)

defect

Tracking

(firefox-esr115 wontfix, firefox119 wontfix, firefox120 wontfix, firefox121 fixed)

RESOLVED FIXED
121 Branch
Tracking Status
firefox-esr115 --- wontfix
firefox119 --- wontfix
firefox120 --- wontfix
firefox121 --- fixed

People

(Reporter: aryx, Assigned: jmaher)

References

Details

Attachments

(1 file)

This task has a crashtest errorsummary file without a line which mentions the duration. It should be provided, Treeherder assumes it is a required property.

I will adjust Treeherder to set duration to 0 (like done for other fallbacks) in a different bug.

Flags: needinfo?(jmaher)

Correction: The task is this one and it contains a duration of null.

{"group": "", "status": "ERROR", "duration": null, "action": "group_result", "line": 13403}
Summary: 'duration' should always be provided by errorsummary file → 'duration' can be `null` in errorsummary file

I see 2 things:

  1. treeherder fix for duration=null to be treated as 0
  2. fix process-crash output to have the group name (especially since we have the testname.

I am not sure of the root cause, the group="" is a problem, and that indicates that we are logging stuff outside of the normal channels (i.e. not using mozlog.crash()) and need to fix that.

Flags: needinfo?(jmaher)

I think I found the reason for the missing data in errorsummary. so #2 should have a patch for review before too long.

Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0bf5a15f1e03 sanitize test name to match group mapping. r=marco
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch

The patch landed in nightly and beta is affected.
:jmaher, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(jmaher)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: