1861142 - Evaluating `:` throws

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

evaluateJSAsync threw an exception: Error: Encountered error while waiting for Helper Result: Error: '' is not a valid command
createToken@resource://devtools/server/actors/webconsole/commands/parser.js:66:13
getCommandAndArgs@resource://devtools/server/actors/webconsole/commands/parser.js:45:45
evalWithDebugger@resource://devtools/server/actors/webconsole/eval-with-debugger.js:129:48
evaluateJS@resource://devtools/server/actors/webconsole.js:949:18

we can probably tweak the isCommand method so it won't match empty ":"

https://searchfox.org/mozilla-central/rev/ffdc4971dc18e1141cb2a90c2b0b776365650270/devtools/server/actors/webconsole/commands/parser.js#18,214-216

const COMMAND_PREFIX = /^:/;
...
function isCommand(string) {
  return COMMAND_PREFIX.test(string);
}

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1861142 - [devtools] Better handle exception while parsing console commands.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c29477373c7
[devtools] Better handle exception while parsing console commands. r=devtools-reviewers,nchevobbe

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6c29477373c7