Closed Bug 1861217 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42749 - Revert "Fix the counters scope removal"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox121 fixed)

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42749 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42749
Details from upstream follow.

Daniil Sakhapov <sakhapov@chromium.org> wrote:

Revert "Fix the counters scope removal"

This reverts commit 43d988ac5cb2a1d9aba18a2db3bd7b5eb9f80911.

Reason for revert: crash reports

Original change's description:

Fix the counters scope removal

Sometimes, during the removal of the first counter of the scope,
one of the children of this scope can become new parent for
other counters in the scope, correctly reparent in such case.

Fixed: 1492599
Change-Id: I20c0a881e6bced174fec567ca8b37e70ae6e894d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4960115
Commit-Queue: Daniil Sakhapov \<sakhapov@chromium.org>
Reviewed-by: Vladimir Levin \<vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1213681}

Change-Id: I7eec5dad34ec2a7b052da431bbbc7255a08cf166

Reviewed-on: https://chromium-review.googlesource.com/4976898
WPT-Export-Revision: b17a88e72f01212094a1508db9fc31f2ae495647

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 42749 applied with additional changes from upstream: 73b565383d671d8db76fb55f4ee714153665fcdc, 0af481e90f13054b5800fd60f9e7d46afcde729a
Whiteboard: [wptsync downstream error] → [wptsync downstream]
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/827e37570128 [wpt PR 42749] - Revert "Fix the counters scope removal", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.