Closed Bug 1861288 Opened 2 years ago Closed 2 years ago

Improve coverage of the pre-export and export phases in profiles

Categories

(Firefox Build System :: General, task)

task

Tracking

(firefox121 fixed)

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

No description provided.

At the top-level, what we currently have is something akin to:
export: some deps
echo BUILDSTATUS TIER_START export
make recurse_export
...

In practice, what this means is that some and deps are built outside
the export tier/phase.

Since recurse_export is itself a recipe with dependencies, we can "just"
move some and deps to become dependencies of recurse_export instead.
But since in non top-level directories, recurse_export is not a thing,
we still need to keep the dependencies on export there.

Unfortunately, we have one instance of something built during
recurse_export that relied on its undeclared/undeclarable dependencies
being built before recurse_export, so we need to accomodate for that.

Also, for some reason, recurse_pre-export was a two-colons recipe, while
the other recurse_* recipes were single-colon, so fix that.

Come to think of it, the same probably applies to misc and libs, which
this would mechanically fix alongside.

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/a8fd3a9117b2 Improve coverage of the pre-export and export phases in profiles. r=firefox-build-system-reviewers,ahochheiden
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: