Closed
Bug 186129
Opened 22 years ago
Closed 22 years ago
SetTextboxFocus() should select textbox contents
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.3final
People
(Reporter: neil, Assigned: neil)
Details
(Keywords: regression)
Attachments
(1 file)
|
1012 bytes,
patch
|
Brade
:
review+
kinmoz
:
superreview+
asa
:
approval1.3b-
asa
:
approval1.3+
|
Details | Diff | Splinter Review |
Now that bug 118038 is fixed we can restore .select() to SetTextboxFocus()
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #109736 -
Flags: superreview?(kin)
Attachment #109736 -
Flags: review?(cmanske)
Attachment #109736 -
Flags: review?(cmanske) → review?(brade)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 109736 [details] [diff] [review]
Proposed patch
remove the commented out lines for textbox.focus and textbox.select
r=brade
Attachment #109736 -
Flags: review?(brade) → review+
|
|
||
Comment 3•22 years ago
|
||
-->Neil since it is his patch and cmanske is vacationing
Assignee: cmanske → neil
OS: Windows 95 → All
Hardware: PC → All
Comment on attachment 109736 [details] [diff] [review]
Proposed patch
sr=kin@netscape.com
Just adddress brade's issues above.
Attachment #109736 -
Flags: superreview?(kin) → superreview+
|
|
Assignee | |
Comment 5•22 years ago
|
||
Comment on attachment 109736 [details] [diff] [review]
Proposed patch
Technically this fixes a regression of bug 103197
Attachment #109736 -
Flags: approval1.3b?
|
|
Assignee | |
Updated•22 years ago
|
Keywords: regression
|
||
Comment 6•22 years ago
|
||
Neil, are you aware of bug 124750?
textbox.focus() is e.g. responsible for chatzilla's focus stealing when new
channels are joined.
I just want to make sure that this fix does not cause a new focus stealing bug...
|
|
Assignee | |
Comment 7•22 years ago
|
||
Andreas, SetTextboxFocus already sets focus (duh!), but without selecting.
|
|
||
Comment 8•22 years ago
|
||
Oh, sorry, I misread the patch... (there is a confusing number of comments...)
|
|
Assignee | |
Comment 9•22 years ago
|
||
Now I know why brade wants them removed :-)
|
||
Comment 10•22 years ago
|
||
Comment on attachment 109736 [details] [diff] [review]
Proposed patch
We're trying to get 1.3beta out the door. This is going to have to wait.
Attachment #109736 -
Flags: approval1.3b? → approval1.3b-
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.3final
|
|
Assignee | |
Updated•22 years ago
|
Attachment #109736 -
Flags: approval1.3?
|
|
||
Comment 11•22 years ago
|
||
Comment on attachment 109736 [details] [diff] [review]
Proposed patch
a=asa (on behalf of drivers) for checkin to 1.3 final.
Attachment #109736 -
Flags: approval1.3? → approval1.3+
|
|
Assignee | |
Comment 12•22 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•