1861309 - Use 1-origin column number in Module APIs and internal objects

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/search?q=ColumnNumberZero&path=Module&case=false&regexp=false

Module-related API and objects use 0-origin column number, but they're for error reporting, which is already using 1-origin column number.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1861309 - Part 1: Use 1-origin column number in JS::GetRequestedModuleSourcePos and ModuleLoaderBase::HandleResolveFailure. r?jonco!

Depends on D192781

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1861309 - Part 2: Use 1-origin column number in module stencils and ThrowResolutionError. r?jonco!

Depends on D192782

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39474a3e2d59
Part 1: Use 1-origin column number in JS::GetRequestedModuleSourcePos and ModuleLoaderBase::HandleResolveFailure. r=jonco
https://hg.mozilla.org/integration/autoland/rev/bf25e4eb7faa
Part 2: Use 1-origin column number in module stencils and ThrowResolutionError. r=jonco

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/39474a3e2d59
https://hg.mozilla.org/mozilla-central/rev/bf25e4eb7faa