1861466 - Implement CustomStateSet

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Keith Cirkel [:keithamus]]

Steps to reproduce:

Tracking issue for https://wicg.github.io/custom-state-pseudo-class/#customstateset

Comment 1

[Keith Cirkel [:keithamus]]

Attachment: Bug 1861466 - Add CustomStateSet and :state() pseudo. r=emilio,smaug,canadahonk

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae536a17c1ff
Add CustomStateSet and :state() pseudo. r=emilio,smaug

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43022 for changes under testing/web-platform/tests

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/ae536a17c1ff

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 6

[Hamish Willee]

Attachment: wpt_customelementtest_121.0a1.png

Just tried this in FF Nightly 121.0a1 with the pref enabled. WPT test does not appear to pass - i.e. as you can see the "I should be green/blue" text is not appropriately coloured. Should this work? This is for MDN docs work.

Comment 7

[Hamish Willee]

FF121 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/30339

Comment 8

[Keith Cirkel [:keithamus]]

Style invalidation still needs some work so changes aren’t always reflected - and is why WPT fails. I’ll be following up with more patches for this.

Comment 9

[Hamish Willee]

Thanks @Keith,

I was wondering if you might confirm something for me:

1. You can only use this feature with autonomous custom elements (only custom elements that don't derive from built-ins). I tried doing a built in and got a DOMException as described here: https://github.com/whatwg/html/issues/5166

Comment 10

[Hamish Willee]

I have set dev-doc-complete - the docs are done on the assumption that the comments above are correct.

Comment 11

[Keith Cirkel [:keithamus]]

(In reply to Hamish Willee from comment #9)

Thanks @Keith,

I was wondering if you might confirm something for me:

1. You can only use this feature with autonomous custom elements (only custom elements that don't derive from built-ins). I tried doing a built in and got a DOMException as described here: https://github.com/whatwg/html/issues/5166

This is my understanding. I believe the docs are already complete, yes.

There are errors with WPT as work still needs to be done to complete this feature.

Comment 12

[Keith Cirkel [:keithamus]]

(To clarify this bug was for CustomStateSet IDL, but the parent issue #1588763 is still open)

Comment 13

[Keith Cirkel [:keithamus]]

I don't know how I set this to reopened but this one should be marked fixed (I can no longer do so)