186149 - [FIXr] scrollIntoView() does not work on dynamically created elements

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[José Jeria]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20021217
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20021217

Have a container (div) containings several divs, when hardcoded, i can use the
scrollIntoView(); to scroll to that element.

But when this element is created dynamically, the scrollIntoView() does not work.
See attached testcase.

Reproducible: Always

Steps to Reproduce:

Comment 1

[José Jeria]

Attachment: Testcase.

Comment 2

[Vladimir Ermakov]

Not dom events->DOM Html?

Comment 3

[Johnny Stenback (:jst)]

Mass-reassigning bugs.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Possible patch

The problem (and this affects scrolling to anchors too) is that we can try to
scroll before the reflow events have been processed...

I suppose I could add the flush to ScrollFrameIntoView itself, but the problem
is that reflow can actually trigger frame reconstruction (for example <object>
will call CantRenderReplacedElement from reflow!).  So we want to call
GetPrimaryFrameFor _after_ we flush....

Comment 5

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 121584 [details] [diff] [review]
Possible patch

sr=jst

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 121584 [details] [diff] [review]
Possible patch

Requesting 1.4b approval; this just makes sure that we reflow before we get the
coordinates we're going to scroll to....

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 121584 [details] [diff] [review]
Possible patch

a=asa (on behalf of drivers) for checkin to 1.4b

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 10

[José Jeria]

Works fine now.