1861688 - Can't change moz-label's or moz-support-link's fluent strings in storybook

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[:Gijs (he/him)]

Hanna mentioned that this storybook may predate the integration of the fluent plugin in storybook, and that may be why you can't change it.

Comment 1

[Hanna Jones [:hjones]]

To elaborate/change the scope of this slightly - our stories for moz-label and moz-support-link were both written before we had the fluent Storybook addon and are using fluent in a way that is effectively deprecated. Both of them load fluent files from a /locales-preview directory that we can get rid of by moving those strings into the stories themselves using the fluent parameter we now support (one example here). So the steps are:

1. change both stories to use the fluent parameter
2. stop calling insertFTLIfNeeded here and here
3. remove everything in browser/locales-preview

Comment 2

[Mark Striemer [:mstriemer]]

This could potentially be fixed by supporting fluent files in the Fluent panel (bug 1826123)

Comment 3

[Catherine Meade]

Attachment: Bug 1861688 - moz-label and moz-support-link have storybook fluent configuration r?#reusable-components-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/321a517f843c
https://hg.mozilla.org/integration/autoland/rev/3e9523df82d6
moz-label and moz-support-link have storybook fluent configuration r=reusable-components-reviewers,mkennedy

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/3e9523df82d6