1861958 - Remove layout.css.container-queries.enabled pref

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Gregory Pappas [:gregp]]

Container queries have been enabled for about a year (bug 1809720). Let's remove this feature rollout pref

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1861958 - Remove layout.css.container-queries.enabled pref r?emilio!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3727941ffb94
Remove layout.css.container-queries.enabled pref r=emilio,devtools-reviewers

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustage on layout.css.container-queries.enabled

• backout: https://hg.mozilla.org/integration/autoland/rev/9d87d8875f3012f1cb5e065b5861f41a29d1173c
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=3727941ffb94d0e5780718b58dad78f586117594
• failure log: https://treeherder.mozilla.org/logviewer?job_id=434351231&repo=autoland&lineNumber=46344

[task 2023-10-30T22:28:33.119Z] 22:28:33     INFO -       Running `CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_CRATE_NAME=webrender CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/gfx/wr/webrender CARGO_PKG_AUTHORS='Glenn Watson <[e-mail]>' CARGO_PKG_DESCRIPTION='A GPU accelerated 2D renderer for web content' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MPL-2.0 CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=webrender CARGO_PKG_README='' CARGO_PKG_REPOSITORY='https://github.com/servo/webrender' CARGO_PKG_RUST_VERSION=[..[[`
[task 2023-10-30T22:28:33.119Z] 22:28:33     INFO -  error: no rules expected the token `"layout.css.container-queries.enabled"`
[task 2023-10-30T22:28:33.119Z] 22:28:33     INFO -     --> servo/components/style/values/specified/length.rs:923:25
[task 2023-10-30T22:28:33.119Z] 22:28:33     INFO -      |
[task 2023-10-30T22:28:33.119Z] 22:28:33     INFO -  923 |     static_prefs::pref!("layout.css.container-queries.enabled")
[task 2023-10-30T22:28:33.120Z] 22:28:33     INFO -      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no rules expected this token in macro call
[task 2023-10-30T22:28:33.120Z] 22:28:33     INFO -      |
[task 2023-10-30T22:28:33.120Z] 22:28:33     INFO -  note: while trying to match `"browser.display.document_color_use"`
[task 2023-10-30T22:28:33.120Z] 22:28:33     INFO -     --> /builds/worker/workspace/obj-build/modules/libpref/static_prefs.rs:94:6
[task 2023-10-30T22:28:33.120Z] 22:28:33     INFO -      |
[task 2023-10-30T22:28:33.121Z] 22:28:33     INFO -  94  |     ("browser.display.document_color_use") => (unsafe { $crate::StaticPrefs_browser_display_document_color_use() });
[task 2023-10-30T22:28:33.121Z] 22:28:33     INFO -      |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2023-10-30T22:28:33.121Z] 22:28:33     INFO -  warning: ignoring -C extra-filename flag due to -o flag
[task 2023-10-30T22:28:33.121Z] 22:28:33     INFO -  warning: `style` (lib) generated 1 warning
[task 2023-10-30T22:28:33.121Z] 22:28:33     INFO -  error: could not compile `style` (lib) due to previous error; 1 warning emitted
[task 2023-10-30T22:28:33.130Z] 22:28:33     INFO -  warning: build failed, waiting for other jobs to finish...

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:gregp, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d062a9fa5bb6
Remove layout.css.container-queries.enabled pref r=emilio,devtools-reviewers

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for for "container" related failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/e3d59279258756518ad838dcb96a1b45b7e64ee2
Log link: https://treeherder.mozilla.org/logviewer?job_id=457961360&repo=autoland&lineNumber=1515

There were also:

• this failure on browser_parsable_css.js
• this failure on test_bug1112014.html

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cdd4d21cf86
Remove layout.css.container-queries.enabled pref r=emilio,devtools-reviewers

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2cdd4d21cf86