1862039 - Consider not using GL_CONTEXT_FLAG_NO_ERROR_BIT to avoid crashes in Mesa

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

See: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9747#note_2148093
and https://gitlab.freedesktop.org/mesa/mesa/-/issues/10062

Comment 1

[Jeff Muizelaar [:jrmuizel]]

This comes from here: https://searchfox.org/mozilla-central/rev/aa8a99510c0686cdf9d42fb4b8f6d968884c961d/dom/canvas/WebGLContext.cpp#275

Thoughts Kelsey?

Comment 2

[Timothy Nikkel (:tnikkel)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)

This comes from here: https://searchfox.org/mozilla-central/rev/aa8a99510c0686cdf9d42fb4b8f6d968884c961d/dom/canvas/WebGLContext.cpp#275

Thoughts Kelsey?

That just got added in bug 1841050 and the pref is flipped on Windows only right now. Perhaps we flip the pref on linux as well?

Comment 3

[Gabriele Svelto [:gsvelto]]

It seems to me that the pref is enabled on macOS and Linux but not on Windows, see here. Maybe the intention was to only enable it on Windows and not vice-versa?

Comment 4

[Timothy Nikkel (:tnikkel)]

I think false + no_error = error, ie return an error in the case of something invalid instead of not checking and letting it through.

Comment 5

[Kelsey Gilbert [:jgilbert]]

We should blocklist to prevent using no_error on unfixed mesa.

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 1862039 - Pref webgl_gl_khr_no_error off on Linux. r=#gfx-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e7d530afef0
Don't set GL_CONTEXT_FLAG_NO_ERROR_BIT with mesa. r=gfx-reviewers,jgilbert,jrmuizel

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for causing GLContext related crashes.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=1e7d530afef0c439ddd2f6158cb5cbf416ce9ab7&selectedTaskRun=Cr4qU7lpSsimZGNR2YOAMw.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=435645407&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=435650113&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/bd03120d6db1fc7c053cc1430f6e6f071432dae1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10f8c40533f1
Pref webgl_gl_khr_no_error off on Linux. r=gfx-reviewers,jgilbert,jrmuizel

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failure on test_2_conformance2__transform_feedback__transform_feedback.html

Backout link

Push with failures

Failure log

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jgilbert, could you have a look please?

For more information, please visit BugBot documentation.

Comment 12

[François]

Attachment: about_support

I believe this bug is affecting me, not 100% sure but it smells the same, however FF crashes so bad I never get any crash info, so that may not be entirely identical. Still I wanted to chime in because it means automated crash report would not show this.

I'm on a fairly recent ubuntu 23.10 install and using firefox from mozilla stable PPA.
On a freshly created profile I load youtube in a few tabs, see a few videos switching around, even switching our of FF to another app, and I quickly get a freeze while the following messages on the command line:
...
MESA: error: Failed to query drm device.
libEGL warning: egl: failed to create dri2 screen
MESA: error: Failed to query drm device.
libEGL warning: egl: failed to create dri2 screen
...

I started to experience the bug fairly recently, or at least it started to hit me really bad a couple days ago and I may not have bothered before.
Let me know if you need more details from me, below are the

Comment 13

[François]

I believe this bug is affecting me, not 100% sure but it smells the same, however FF crashes so bad I never get any crash info, so that may not be entirely identical. Still I wanted to chime in because it means automated crash report would not show this.

I'm on a fairly recent ubuntu 23.10 install and using firefox from mozilla stable PPA.
On a freshly created profile I quickly get a freeze loading youtube in a few tabs, seeing a few videos, switching out of FF to another app (something the failed test mentioned in #10 seems to care about), and on the command line I get:

MESA: error: Failed to query drm device.
libEGL warning: egl: failed to create dri2 screen
MESA: error: Failed to query drm device.
libEGL warning: egl: failed to create dri2 screen

I started to experience the bug fairly recently, or at least it started to hit me really bad a couple days ago and I may not have bothered before.
Attached is the about:config report copied listerally just before a freeze.

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Nical, where did this end up?

Comment 15

[Nicolas Silva [:nical]]

There are a couple of tests that fail if GL_CONTEXT_FLAG_NO_ERROR_BIT is set (they generate an error). I haven't investigated that much. I should probably have marked them as failing on linux and re-landed but it fell of the radar.

Comment 16

[François]

(In reply to François from comment #13)

I believe this bug is affecting me, not 100% sure but it smells the same, however FF crashes so bad I never get any crash info, so that may not be entirely identical. Still I wanted to chime in because it means automated crash report would not show this.

I'm on a fairly recent ubuntu 23.10 install and using firefox from mozilla stable PPA.
On a freshly created profile I quickly get a freeze loading youtube in a few tabs, seeing a few videos, switching out of FF to another app (something the failed test mentioned in #10 seems to care about), and on the command line I get:

MESA: error: Failed to query drm device.
libEGL warning: egl: failed to create dri2 screen
MESA: error: Failed to query drm device.
libEGL warning: egl: failed to create dri2 screen

I started to experience the bug fairly recently, or at least it started to hit me really bad a couple days ago and I may not have bothered before.
Attached is the about:config report copied listerally just before a freeze.

Release 120.0.1 seems to have fixed my issue which most likely was not related to this ticket.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81395545d414
Pref webgl_gl_khr_no_error off on Linux. r=gfx-reviewers,jgilbert,jrmuizel

Comment 18

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/81395545d414