Investigate if 2 tests of PanelMultiView in Customizable UI need to be updated to pass a11y_checks
Categories
(Firefox :: Settings UI, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox121 | --- | fixed |
People
(Reporter: ayeddi, Assigned: ayeddi)
References
Details
Attachments
(1 file)
There are 2 failing tests for the PanelMultiView
s that appear to create mock toolbarbutton and panel for the purposes of testing PanelMultiView, but the anchor (gAnchor
) or a toggle (gToggle
) do not have an a11y label (because they were not really intended to be seen by a user).
We could add a test label for each of them to keep the test harness happy.
a11y_checks failing data (with stack trace):
FAIL browser/components/customizableui/test/browser_PanelMultiView_focus.js Interactive elements must be labeled toolbarbutton "
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:510
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:670
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_focus.js:testMainViewByClick/<:88
resource://testing-common/CustomizableUITestUtils.sys.mjs:openPanelMultiView:65
chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_focus.js:testMainViewByClick:87
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"
FAIL browser/components/customizableui/test/browser_PanelMultiView_keyboard.js Interactive elements must be labeled moz-toggle-button button toggle-button "
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:510
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:670
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeKey:1424
chrome://mochitests/content/browser/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js:testMozToggle:575
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"
Assignee | ||
Comment 1•1 year ago
|
||
There are 2 failing tests for the PanelMultiView
s that appear to create mock toolbarbutton and panel for the purposes of testing PanelMultiView, but the anchor (gAnchor
) or a toggle (gToggle
) do not have an a11y label (because they were not really intended to be seen by a user).
We are adding a test label for each of them to keep the a11y_checks test harness happy and removing the fail-if
annotations from the test manifest that was added by bug 1854536 before the investigation in the meta bug 1854537.
Comment 3•1 year ago
|
||
bugherder |
Description
•