1862102 - [toolbar redesign] update Custom tab toolbar action buttons phase 1

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P1)

Description

[Mike a [:mavduevskiy]]

Design could be found here

Comment 1

[[:harrisono]]

Attachment: Bug 1862102 - Add Share and Reload buttons to CustomTabsToolbarFeature

Bug 1862102 - Add Share and Reload buttons to CustomTabsToolbarFeature

• browser-toolbar
  • Added a new method for addReloadButton and new param for reloadListener to CustomTabsToolbarFeature, see Bug 1862102.

Comment 2

[Mike a [:mavduevskiy]]

Attachment: Bug 1862102 - Fix toolbar actions overlapping each other

Comment 3

[Phabricator Automation]

Comment on attachment 9397513 [details]
Bug 1862102 - Fix toolbar actions overlapping each other

Revision D207955 was moved to bug 1889240. Setting attachment 9397513 [details] to obsolete.

Comment 4

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Nightly blockers to priority P1.

Comment 5

[[:harrisono]]

Attachment: Bug 1862102 - Add Share button to CustomTabsToolbarFeature

Comment 6

[[:harrisono]]

Attachment: chromeCurrentCustomTabs.png

This screenshot shows the Chrome Custom Tab implementation for this Youtube Custom Tab.

note that the "share" button has been enabled by default. (the "showShareButton" flag is not set to true in the CustomTabIntent config for this intent).

Comment 7

[[:harrisono]]

I know there has been some concern about adding the Share button by default to the Custom Tabs Toolbar when there is a field in CustomTabsIntent that asks for a share button to be shown. I think that is ok to add the Share button by default because Google Chrome already does this and Google is the owner of Android. If they are doing something (barring crazy privacy violations), I think we can feel safe doing it too.

See screenshot attached above for Chrome's implementation.

Comment 8

[[:harrisono]]

Unfortunately today I have a bit of a problem to bring forward.

after a discussion with several other engineers, we have determined that there is a spec problem with implementing the “Share” button by default for Custom Tabs on Android.
https://developer.chrome.com/docs/android/custom-tabs/guide-interactivity#enable_the_default_share_action

According to this developer document, apps are able to implement their own share button with their own logic and limitations to Custom Tabs and this can result in two share buttons being visible on the toolbar.

https://developer.android.com/reference/androidx/browser/customtabs/CustomTabsIntent#SHARE_STATE_OFF()

There is also this field in the Custom Tab config that can set to “never show share” which our current implementation does respect but a default “share” button on the custom tabs toolbar would not follow the spec.

Comment 9

[Joe M [:jmahon]]

Harrison, is this still expected to be done in Phase 1? (as a blocker for landing in Nightly?)

Comment 10

[[:harrisono]]

Yes, this will be closed when this PR is merged.