Open Bug 1862120 Opened 3 years ago Updated 2 years ago

Several MEMORY_* histograms are unused

Categories

(Core :: Memory Allocator, task)

task

Tracking

()

People

(Reporter: pbone, Unassigned)

References

(Blocks 1 open bug)

Details

There are several unused MEMORY_* histograms, such as MEMORY_RESIDENT and MEMORY_HEAP_COMMITTED. Do we want to remove them or add them back in. Maybe committed is useful but there are new histograms for resident. There are possibly others.

NI @mccr8, maybe @smaug. I don't want to remove these without checking with yourselves or anyone else concerned with MemShrink.

Thanks.

Flags: needinfo?(smaug)
Flags: needinfo?(continuation)

(In reply to Paul Bone [:pbone] from comment #0)

There are several unused MEMORY_* histograms, such as MEMORY_RESIDENT and MEMORY_HEAP_COMMITTED. Do we want to remove them or add them back in. Maybe committed is useful but there are new histograms for resident. There are possibly others.

Moving this to Firefox::General as this is about metrics being collected and not about the data collection system itself. Please move it back if you feel this is wrong.

Component: Telemetry → General
Product: Toolkit → Firefox

MEMORY_RESIDENT_FAST and MEMORY_RESIDENT_PEAK are both used (and I'd keep those), and I don't see a probe MEMORY_RESIDENT.
mozilla-central doesn't seem to have MEMORY_HEAP_COMMITTED.

Flags: needinfo?(smaug)
Component: General → Memory Allocator
Flags: needinfo?(continuation)
Product: Firefox → Core

I haven't looked at memory telemetry in a long time, so whatever is fine with me.

Blocks: 1913576
You need to log in before you can comment on or make changes to this bug.