1862179 - Disable pref network.send_OnDataFinished_after_progress_updates

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Description

[Sunil Mayya]

In our current OMT design, we are sending OnDataFinished event only after are we have dispatched the OnProgress events on Main thread.
This can have performance impacts and had been put under a pref network.send_OnDataFinished_after_progress_updates.
Although this was not part of the original design, we had to introduce this behavior due to this issue. Now the devtool issue has been fixed. We can disable the pref and re-enable it back if we see similar issues in future.

Comment 1

[Sunil Mayya]

Attachment: Bug 1862179 - disable pref pref network.send_OnDataFinished_after_progress_updates. r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7673216b5d4e
disable pref  pref network.send_OnDataFinished_after_progress_updates. r=jesup

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7673216b5d4e

Comment 4

[Alex Finder]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7673216b5d4e
disable pref pref network.send_OnDataFinished_after_progress_updates.
r=jesup

== Change summary for alert #40101 (as of Fri, 03 Nov 2023 12:19:38 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
12%	linkedin fcp	linux1804-64-shippable-qr	fission warm webrender	173.29 -> 152.92	Before/After
11%	linkedin FirstVisualChange	linux1804-64-shippable-qr	fission warm webrender	186.54 -> 166.39	Before/After
9%	linkedin fcp	linux1804-64-shippable-qr	cold fission webrender	617.94 -> 559.64	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40101