Closed Bug 1862187 Opened 1 year ago Closed 1 year ago

switch Eliot to use PORT for gunicorn

Categories

(Eliot :: General, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: relud)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Before we extracted Eliot from the Tecken repository and deploy pipeline, we needed the two services to have non-overlapping environment variables.

Now that we've got Eliot in a separate repository and deploy pipeline, we should change it from using ELIOT_GUNICORN_PORT to use PORT which is the Dockerflow standard variable. This will reduce confusion in the infrastructure configuration.

I'm pretty sure this is a minor change. We need to change instances of ELIOT_GUNICORN_PORT to PORT in this script:

https://github.com/mozilla-services/eliot/blob/c0d8e44920979bd38efada84d548e8540e7bf923/bin/run_eliot_web.sh#L8

and in the docs:

https://github.com/mozilla-services/eliot/blob/c0d8e44920979bd38efada84d548e8540e7bf923/docs/configuration.rst#L44-L50

We should wait to do this until after Eliot is in the webservices GKE cluster.

Keywords: good-first-bug
Assignee: nobody → dthorn
Status: NEW → ASSIGNED

this will also make it so that PORT as set docker/Dockerfile is respected

fixed in v2024.01.11

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: