1862209 - [wpt-sync] Sync PR 42866 - Add invokeaction logic for fullscreen API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42866 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42866
Details from upstream follow.

Luke Warlow <[e-mail]> wrote:

Add invokeaction logic for fullscreen API

This adds the logic on how buttons with an invokeaction related to
fullscreen should behave, based on the Invokers proposal.

See explainer section here:
https://open-ui.org/components/invokers.explainer/#defaults.

This adds to the HandleInvokeInternal on HTMLElement with the
toggleFullscreen, exitFullscreen and requestFullscreen actions.

Bug: 1497171
Change-Id: Ic8a2c7e2f686f8b22c3d133579184d492ebbc330
Reviewed-on: https://chromium-review.googlesource.com/4987781
WPT-Export-Revision: 64f912a2d0f35f533c48fcdf66fb8f5faaae2c9a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1fcdaa171d00046869188b09b07f0eb05366a7ea

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 11 subtests

Status Summary

Firefox

OK : 1
PASS: 6
FAIL: 5

Chrome

OK : 1
PASS: 6
FAIL: 5

Safari

OK : 1
PASS: 6
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/invokers/invoketarget-fullscreen-behavior.tentative.html [wpt.fyi]
  • invoking div with toggleFullscreen action makes div fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoking fullscreen div with toggleFullscreen action exits fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoking fullscreen div with toggleFullscreen (case-insensitive) action exits fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoking div with requestFullscreen action makes div fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)
  • invoking fullscreen div with exitFullscreen action exits fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f50d044e96ea
[wpt PR 42866] - Add invokeaction logic for fullscreen API, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c66948683298
[wpt PR 42866] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9b2a7393597
[wpt PR 42866] - Add invokeaction logic for fullscreen API, a=testonly
https://hg.mozilla.org/integration/autoland/rev/28dca14e41e8
[wpt PR 42866] - Update wpt metadata, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c9b2a7393597
https://hg.mozilla.org/mozilla-central/rev/28dca14e41e8