1862378 - Changes to mozjemalloc's committed memory calculation

Status: RESOLVED FIXED

(Core :: Memory Allocator, task)

Description

[Paul Bone [:pbone]]

As I was working on Bug 1857841 I kept hitting assertions with the amount of committed memory. So I added more assertions to catch problems sooner and made other changes to committed memory to make sure it was correct.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1862378 - Simplify some ifdef conditions r=glandium

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1862378 - Track the number of committed pages in a chunk r=glandium

I wrote this to help me with debugging. I was finding that the committed
memory would end up larger than the mapped memory when jemalloc_stats() was
called. To figure out why I added this counter to each chunk and check that
it remains in bounds and that when we dispose the chunk that it returns to
0.

It's only build when MOZ_DEBUG is defined

Depends on D192447

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1862378 - Add assertion for waste calculation r=glandium

The waste memory calcuation has an invariant that we can also assert.

Depends on D192448

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1862378 - Chunk guard pages are not committed memory r=glandium

Don't include the chunk guard pages in our committed memory calculation.

Depends on D192449

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a34246d067fa
Simplify some ifdef conditions r=glandium
https://hg.mozilla.org/integration/autoland/rev/d41876c49d2d
Add assertion for waste calculation r=glandium
https://hg.mozilla.org/integration/autoland/rev/81c46dfe35a0
Chunk guard pages are not committed memory r=glandium

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a34246d067fa
https://hg.mozilla.org/mozilla-central/rev/d41876c49d2d
https://hg.mozilla.org/mozilla-central/rev/81c46dfe35a0